feat(flagd): migrate to new provider mode file and update e2e tests by aepfli · Pull Request #121 · open-feature/python-sdk-contrib · GitHub
Skip to content

feat(flagd): migrate to new provider mode file and update e2e tests - #121

Merged
toddbaert merged 15 commits into
open-feature:mainfrom
open-feature-forking:feat/gherkinmigration
Feb 6, 2025
Merged

feat(flagd): migrate to new provider mode file and update e2e tests#121
toddbaert merged 15 commits into
open-feature:mainfrom
open-feature-forking:feat/gherkinmigration

Conversation

@aepfli

@aepfli aepfli commented Dec 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

see open-feature/flagd#1504

this pr migrates the offline file provider in a backwards-compatible manner to its own provider.

Furthermore, we're updating the test harness to the new testbed approach.

@aepfli
feat(flagd-rpc): add caching with tests
9331acc 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
fixup: using new test-harness
ed6aa0f 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
fixup(flagd): remove merge conflict error as stated by warber
28bd80d 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
feat(flagd): add graceful attempts
1a0a582 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
feat(flagd): add graceful attempts
ca8d18b 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
fixup: rename method
e057196 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
fixup: naming linting
335cce7 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
aepfli force-pushed the feat/gherkinmigration branch from bd916e4 to 527ce6b Compare December 17, 2024 20:08
@aepfli aepfli changed the title [Draft] improve gherkin setup based on current motivation feat(flagd): improve gherkin setup based on current motivation Dec 18, 2024
@aepfli aepfli changed the title feat(flagd): improve gherkin setup based on current motivation feat(flagd): improve gherkin setup based on current motivation -wip Dec 18, 2024
@aepfli
feat: better reconnect gherkins
578692f 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
aepfli force-pushed the feat/gherkinmigration branch from 527ce6b to 578692f Compare December 18, 2024 06:39
@aepfli aepfli changed the title feat(flagd): improve gherkin setup based on current motivation -wip test(flagd): improve gherkin setup based on current motivation -wip Dec 27, 2024
@codecov

codecov Bot commented Dec 27, 2024 •
edited
Loading

Copy link
Copy Markdown

@aepfli
aepfli force-pushed the feat/gherkinmigration branch 4 times, most recently from 35790da to 455d51d Compare December 27, 2024 15:18
@aepfli
Merge remote-tracking branch 'upstream/main' into feat/gherkinmigration
9192c77 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
aepfli force-pushed the feat/gherkinmigration branch from 455d51d to 9192c77 Compare December 27, 2024 15:19
@aepfli aepfli mentioned this pull request Dec 29, 2024
Merged
@aepfli
Merge branch 'main' into feat/gherkinmigration
6d86a96 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
aepfli force-pushed the feat/gherkinmigration branch 6 times, most recently from 55feac0 to 1a8000b Compare January 8, 2025 19:31
@aepfli
aepfli force-pushed the feat/gherkinmigration branch 6 times, most recently from 77961c8 to 1e2803c Compare February 4, 2025 13:56
beeme1mr
beeme1mr approved these changes Feb 4, 2025
View reviewed changes
Comment thread providers/openfeature-provider-flagd/tests/e2e/file/conftest.py Outdated
@aepfli
aepfli force-pushed the feat/gherkinmigration branch from 1e2803c to 6a299b1 Compare February 4, 2025 17:33
@aepfli

aepfli commented Feb 4, 2025

Copy link
Copy Markdown
Member Author

@aepfli
aepfli force-pushed the feat/gherkinmigration branch from 6a299b1 to 1050ca0 Compare February 4, 2025 17:35
@aepfli
Merge branch 'main' into feat/gherkinmigration
a5990a3 
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
@aepfli
aepfli force-pushed the feat/gherkinmigration branch from 1050ca0 to a5990a3 Compare February 4, 2025 17:36
@toddbaert
toddbaert merged commit eed1ee0 into open-feature:main Feb 6, 2025
@github-actions github-actions Bot mentioned this pull request Feb 3, 2025
Merged
@aepfli aepfli mentioned this pull request Feb 8, 2025
Open
aepfli added a commit that referenced this pull request Sep 13, 2026
@aepfli
chore(flagd): ignore the flag file every e2e run generates
d15cfe4 
`FlagdContainer` creates `./flags` relative to the package directory and points
the launchpad's FLAGS_DIR at it, so every e2e run leaves a 27KB
`providers/openfeature-provider-flagd/flags/allFlags.json` behind. The directory
is tracked through a `.gitkeep` and no ignore rule matches the file, so the
working tree is dirty after any run and a `git add -A` commits a generated
fixture.

The rule is the one this package already wrote for the same file in the other
flag directory: `tests/flags/.gitignore` has contained exactly `allFlags.json`
since #121. This is that line, next to the directory that now receives it.

Unrelated to the conformance suite, which drives its stack through Compose and
writes nothing here -- it is in this branch because this is the branch that
touches this package, and it reverts on its own.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli added a commit that referenced this pull request Sep 13, 2026
@aepfli
chore(flagd): ignore the flag file every e2e run generates
7846b6f 
`FlagdContainer` creates `./flags` relative to the package directory and points
the launchpad's FLAGS_DIR at it, so every e2e run leaves a 27KB
`providers/openfeature-provider-flagd/flags/allFlags.json` behind. The directory
is tracked through a `.gitkeep` and no ignore rule matches the file, so the
working tree is dirty after any run and a `git add -A` commits a generated
fixture.

The rule is the one this package already wrote for the same file in the other
flag directory: `tests/flags/.gitignore` has contained exactly `allFlags.json`
since #121. This is that line, next to the directory that now receives it.

Unrelated to the conformance suite, which drives its stack through Compose and
writes nothing here -- it is in this branch because this is the branch that
touches this package, and it reverts on its own.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli added a commit that referenced this pull request Sep 13, 2026
@aepfli
chore(flagd): ignore the flag file every e2e run generates
5d1f9b3 
`FlagdContainer` creates `./flags` relative to the package directory and points
the launchpad's FLAGS_DIR at it, so every e2e run leaves a 27KB
`providers/openfeature-provider-flagd/flags/allFlags.json` behind. The directory
is tracked through a `.gitkeep` and no ignore rule matches the file, so the
working tree is dirty after any run and a `git add -A` commits a generated
fixture.

The rule is the one this package already wrote for the same file in the other
flag directory: `tests/flags/.gitignore` has contained exactly `allFlags.json`
since #121. This is that line, next to the directory that now receives it.

Unrelated to the conformance suite, which drives its stack through Compose and
writes nothing here -- it is in this branch because this is the branch that
touches this package, and it reverts on its own.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli added a commit that referenced this pull request Sep 14, 2026
@aepfli
chore(flagd): ignore the flag file every e2e run generates
0a6ca9a 
`FlagdContainer` creates `./flags` relative to the package directory and points
the launchpad's FLAGS_DIR at it, so every e2e run leaves a 27KB
`providers/openfeature-provider-flagd/flags/allFlags.json` behind. The directory
is tracked through a `.gitkeep` and no ignore rule matches the file, so the
working tree is dirty after any run and a `git add -A` commits a generated
fixture.

The rule is the one this package already wrote for the same file in the other
flag directory: `tests/flags/.gitignore` has contained exactly `allFlags.json`
since #121. This is that line, next to the directory that now receives it.

Unrelated to the conformance suite, which drives its stack through Compose and
writes nothing here -- it is in this branch because this is the branch that
touches this package, and it reverts on its own.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli added a commit that referenced this pull request Sep 15, 2026
@aepfli
chore(flagd): ignore the flag file every e2e run generates
c855c41 
`FlagdContainer` creates `./flags` relative to the package directory and points
the launchpad's FLAGS_DIR at it, so every e2e run leaves a 27KB
`providers/openfeature-provider-flagd/flags/allFlags.json` behind. The directory
is tracked through a `.gitkeep` and no ignore rule matches the file, so the
working tree is dirty after any run and a `git add -A` commits a generated
fixture.

The rule is the one this package already wrote for the same file in the other
flag directory: `tests/flags/.gitignore` has contained exactly `allFlags.json`
since #121. This is that line, next to the directory that now receives it.

Unrelated to the conformance suite, which drives its stack through Compose and
writes nothing here -- it is in this branch because this is the branch that
touches this package, and it reverts on its own.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli added a commit that referenced this pull request Sep 16, 2026
@aepfli
chore(flagd): ignore the flag file every e2e run generates
0ea2044 
`FlagdContainer` creates `./flags` relative to the package directory and points
the launchpad's FLAGS_DIR at it, so every e2e run leaves a 27KB
`providers/openfeature-provider-flagd/flags/allFlags.json` behind. The directory
is tracked through a `.gitkeep` and no ignore rule matches the file, so the
working tree is dirty after any run and a `git add -A` commits a generated
fixture.

The rule is the one this package already wrote for the same file in the other
flag directory: `tests/flags/.gitignore` has contained exactly `allFlags.json`
since #121. This is that line, next to the directory that now receives it.

Unrelated to the conformance suite, which drives its stack through Compose and
writes nothing here -- it is in this branch because this is the branch that
touches this package, and it reverts on its own.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli added a commit that referenced this pull request Sep 16, 2026
@aepfli
chore(flagd): ignore the flag file every e2e run generates
6830da3 
`FlagdContainer` creates `./flags` relative to the package directory and points
the launchpad's FLAGS_DIR at it, so every e2e run leaves a 27KB
`providers/openfeature-provider-flagd/flags/allFlags.json` behind. The directory
is tracked through a `.gitkeep` and no ignore rule matches the file, so the
working tree is dirty after any run and a `git add -A` commits a generated
fixture.

The rule is the one this package already wrote for the same file in the other
flag directory: `tests/flags/.gitignore` has contained exactly `allFlags.json`
since #121. This is that line, next to the directory that now receives it.

Unrelated to the conformance suite, which drives its stack through Compose and
writes nothing here -- it is in this branch because this is the branch that
touches this package, and it reverts on its own.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli added a commit that referenced this pull request Oct 1, 2026
@aepfli
chore(flagd): ignore the flag file every e2e run generates
0c21e4d 
`FlagdContainer` creates `./flags` relative to the package directory and points
the launchpad's FLAGS_DIR at it, so every e2e run leaves a 27KB
`providers/openfeature-provider-flagd/flags/allFlags.json` behind. The directory
is tracked through a `.gitkeep` and no ignore rule matches the file, so the
working tree is dirty after any run and a `git add -A` commits a generated
fixture.

The rule is the one this package already wrote for the same file in the other
flag directory: `tests/flags/.gitignore` has contained exactly `allFlags.json`
since #121. This is that line, next to the directory that now receives it.

Unrelated to the conformance suite, which drives its stack through Compose and
writes nothing here -- it is in this branch because this is the branch that
touches this package, and it reverts on its own.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli added a commit that referenced this pull request Oct 2, 2026
@aepfli
chore(flagd): ignore the flag file every e2e run generates
6d797fc 
`FlagdContainer` creates `./flags` relative to the package directory and points
the launchpad's FLAGS_DIR at it, so every e2e run leaves a 27KB
`providers/openfeature-provider-flagd/flags/allFlags.json` behind. The directory
is tracked through a `.gitkeep` and no ignore rule matches the file, so the
working tree is dirty after any run and a `git add -A` commits a generated
fixture.

The rule is the one this package already wrote for the same file in the other
flag directory: `tests/flags/.gitignore` has contained exactly `allFlags.json`
since #121. This is that line, next to the directory that now receives it.

Unrelated to the conformance suite, which drives its stack through Compose and
writes nothing here -- it is in this branch because this is the branch that
touches this package, and it reverts on its own.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli added a commit that referenced this pull request Oct 8, 2026
@aepfli
chore(flagd): ignore the flag file every e2e run generates
d926f0e 
`FlagdContainer` creates `./flags` relative to the package directory and points
the launchpad's FLAGS_DIR at it, so every e2e run leaves a 27KB
`providers/openfeature-provider-flagd/flags/allFlags.json` behind. The directory
is tracked through a `.gitkeep` and no ignore rule matches the file, so the
working tree is dirty after any run and a `git add -A` commits a generated
fixture.

The rule is the one this package already wrote for the same file in the other
flag directory: `tests/flags/.gitignore` has contained exactly `allFlags.json`
since #121. This is that line, next to the directory that now receives it.

Unrelated to the conformance suite, which drives its stack through Compose and
writes nothing here -- it is in this branch because this is the branch that
touches this package, and it reverts on its own.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli added a commit that referenced this pull request Oct 9, 2026
@aepfli
chore(flagd): ignore the flag file every e2e run generates
b1e9a0c 
`FlagdContainer` creates `./flags` relative to the package directory and points
the launchpad's FLAGS_DIR at it, so every e2e run leaves a 27KB
`providers/openfeature-provider-flagd/flags/allFlags.json` behind. The directory
is tracked through a `.gitkeep` and no ignore rule matches the file, so the
working tree is dirty after any run and a `git add -A` commits a generated
fixture.

The rule is the one this package already wrote for the same file in the other
flag directory: `tests/flags/.gitignore` has contained exactly `allFlags.json`
since #121. This is that line, next to the directory that now receives it.

Unrelated to the conformance suite, which drives its stack through Compose and
writes nothing here -- it is in this branch because this is the branch that
touches this package, and it reverts on its own.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli added a commit that referenced this pull request Oct 14, 2026
@aepfli
chore(flagd): ignore the flag file every e2e run generates
dc5d3f2 
`FlagdContainer` creates `./flags` relative to the package directory and points
the launchpad's FLAGS_DIR at it, so every e2e run leaves a 27KB
`providers/openfeature-provider-flagd/flags/allFlags.json` behind. The directory
is tracked through a `.gitkeep` and no ignore rule matches the file, so the
working tree is dirty after any run and a `git add -A` commits a generated
fixture.

The rule is the one this package already wrote for the same file in the other
flag directory: `tests/flags/.gitignore` has contained exactly `allFlags.json`
since #121. This is that line, next to the directory that now receives it.

Unrelated to the conformance suite, which drives its stack through Compose and
writes nothing here -- it is in this branch because this is the branch that
touches this package, and it reverts on its own.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli added a commit that referenced this pull request Oct 14, 2026
@aepfli
chore(flagd): ignore the flag file every e2e run generates
805c8a9 
`FlagdContainer` creates `./flags` relative to the package directory and points
the launchpad's FLAGS_DIR at it, so every e2e run leaves a 27KB
`providers/openfeature-provider-flagd/flags/allFlags.json` behind. The directory
is tracked through a `.gitkeep` and no ignore rule matches the file, so the
working tree is dirty after any run and a `git add -A` commits a generated
fixture.

The rule is the one this package already wrote for the same file in the other
flag directory: `tests/flags/.gitignore` has contained exactly `allFlags.json`
since #121. This is that line, next to the directory that now receives it.

Unrelated to the conformance suite, which drives its stack through Compose and
writes nothing here -- it is in this branch because this is the branch that
touches this package, and it reverts on its own.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli added a commit that referenced this pull request Oct 16, 2026
@aepfli
chore(flagd): ignore the flag file every e2e run generates
060c0e2 
`FlagdContainer` creates `./flags` relative to the package directory and points
the launchpad's FLAGS_DIR at it, so every e2e run leaves a 27KB
`providers/openfeature-provider-flagd/flags/allFlags.json` behind. The directory
is tracked through a `.gitkeep` and no ignore rule matches the file, so the
working tree is dirty after any run and a `git add -A` commits a generated
fixture.

The rule is the one this package already wrote for the same file in the other
flag directory: `tests/flags/.gitignore` has contained exactly `allFlags.json`
since #121. This is that line, next to the directory that now receives it.

Unrelated to the conformance suite, which drives its stack through Compose and
writes nothing here -- it is in this branch because this is the branch that
touches this package, and it reverts on its own.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
aepfli added a commit that referenced this pull request Oct 16, 2026
@aepfli
chore(flagd): ignore the flag file every e2e run generates
522e52a 
`FlagdContainer` creates `./flags` relative to the package directory and points
the launchpad's FLAGS_DIR at it, so every e2e run leaves a 27KB
`providers/openfeature-provider-flagd/flags/allFlags.json` behind. The directory
is tracked through a `.gitkeep` and no ignore rule matches the file, so the
working tree is dirty after any run and a `git add -A` commits a generated
fixture.

The rule is the one this package already wrote for the same file in the other
flag directory: `tests/flags/.gitignore` has contained exactly `allFlags.json`
since #121. This is that line, next to the directory that now receives it.

Unrelated to the conformance suite, which drives its stack through Compose and
writes nothing here -- it is in this branch because this is the branch that
touches this package, and it reverts on its own.

Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aepfli @beeme1mr @toddbaert