fix: remove spec hashing as we do not use it by Skarlso · Pull Request #99 · open-component-model/replication-controller · GitHub
Skip to content
This repository was archived by the owner on Dec 2, 2025. It is now read-only.

fix: remove spec hashing as we do not use it#99

Merged
Skarlso merged 2 commits into
mainfrom
remove-spec-hash
Dec 7, 2023
Merged

fix: remove spec hashing as we do not use it#99
Skarlso merged 2 commits into
mainfrom
remove-spec-hash

Conversation

@Skarlso

@Skarlso Skarlso commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Skarlso Skarlso requested review from phoban01 and souleb December 6, 2023 17:17
@github-actions

github-actions Bot commented Dec 6, 2023

Copy link
Copy Markdown

@Skarlso Skarlso force-pushed the remove-spec-hash branch 3 times, most recently from a84e4b2 to 9531468 Compare December 7, 2023 06:48
Comment thread go.mod Outdated
@Skarlso Skarlso merged commit a64c598 into main Dec 7, 2023
@Skarlso Skarlso deleted the remove-spec-hash branch December 7, 2023 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants