fix(rocq): narrow proof dependencies after discovery by Alizter · Pull Request #16651 · ocaml/dune · GitHub
Skip to content

fix(rocq): narrow proof dependencies after discovery - #16651

Draft
Alizter wants to merge 2 commits into
ocaml:mainfrom
Alizter:perf-rocq-narrow-proof-deps
Draft

Alizter wants to merge 2 commits into
ocaml:mainfrom
Alizter:perf-rocq-narrow-proof-deps

Conversation

@Alizter

@Alizter Alizter commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Keep the full plugin layout dependency on per-theory discovery; compilation and extraction use rocqdep-reported dependencies. This avoids recompiling unrelated proofs after layout changes while preserving discovery sandbox inputs.

Relies on complete plugin-input reporting by rocqdep, which needs review across supported versions. Regression tests precede the fix. Independent of #16649 and #16650.

Validated @check, @fmt, package-materialization tests, and Rocq tests. Full test suite not run.

Extend plugin layout coverage to literal filenames and mixed-section
content and membership edits. Record the conservative proof recompilation
before narrowing, while checking actual sandbox files and exclusions.

Signed-off-by: Ali Caglayan <alizter@gmail.com>
Prepare the complete plugin layout for dependency discovery, then use
rocqdep-reported dependencies for compilation and extraction. Avoid
recompiling proofs after unrelated plugin-layout changes while retaining
native plugin and transitive proof dependencies.

Keep this change independent of mixed-directory grouping and environment
construction optimizations.

Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter
Alizter force-pushed the perf-rocq-narrow-proof-deps branch from a061495 to 8847757 Compare October 19, 2026 13:04
@Alizter Alizter mentioned this pull request Oct 19, 2026
31 of 52 tasks
@Alizter Alizter added rocq Dune support for the Rocq proof assistant slop Needs to be desloppified. labels Oct 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rocq Dune support for the Rocq proof assistant slop Needs to be desloppified.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant