{{ message }}
Repository navigation
fix(sandbox): reject existing destinations when copying inputs - #16632
Merged
Merged
Conversation
Alizter
force-pushed
the
push-vmtwyqlvkyup
branch
from
October 17, 2026 18:22
927b691 to
8bde9b1
Compare
Alizter
marked this pull request as ready for review
October 17, 2026 18:23
Alizter
force-pushed
the
push-vmtwyqlvkyup
branch
2 times, most recently
from
October 17, 2026 19:07
e268304 to
539c856
Compare
Alizter
force-pushed
the
push-vmtwyqlvkyup
branch
from
October 20, 2026 11:03
539c856 to
a7f4b08
Compare
rgrinberg
approved these changes
Oct 21, 2026
rgrinberg
left a comment
rgrinberg
left a comment
Member
There was a problem hiding this comment.
Instead of "exclusive", I would prefer the name "overwrite" instead.
rgrinberg
reviewed
Oct 21, 2026
rgrinberg
reviewed
Oct 21, 2026
Member
There was a problem hiding this comment.
I think there's a flag to overwrite with copyfile. So none of this should be necessary.
Collaborator
Author
There was a problem hiding this comment.
On macos, the flag is implemented using remove rather than unlink which can delete directories too. This means it will differ in behaviour from Linux. Do you think that's a big deal?
Member
There was a problem hiding this comment.
I don't know. But given that it's not the same, let's just not touch it.
Alizter
force-pushed
the
push-vmtwyqlvkyup
branch
from
October 21, 2026 14:27
a7f4b08 to
fd60346
Compare
Allow Io.copy_file to choose if files are able to overwritten. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-vmtwyqlvkyup
branch
from
October 21, 2026 14:51
fd60346 to
14b36d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
Io.copy_filecallers to choose exclusive creation or overwriting. Reject existing destinations during copy and patch-back sandbox population.This implements Rudi's request in #16596 to stop silent overwriting in copy mode before fixing the overlapping directory dependencies behind #16547. It updates the reproduction from #16626; resolving the overlap itself remains a separate change.