{{ message }}
#7988: name the missing map key in the error - #8012
Open
AzazelSensei wants to merge 2 commits into
Open
Conversation
The missing-key message printed a hash the caller never saw, and said "does not exists". It now names the key as text, or as its bytes when the key is not UTF-8.
Contributor
This was referenced Aug 31, 2026
Member
|
The Generated by Claude Code |
Member
|
fast (ubuntu-24.04) is red on this PR. Not merging until CI is green. Generated by Claude Code |
yegor256
self-requested a review
September 1, 2026 06:42
%s of a number's bytes is valid UTF-8, so recovered never fell through to %x. A key is treated as text only when it has length.
Author
|
fast was red on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A missing key used to print its hash ("Object by hash code %d from given key does not exists"). I don't have that number, and the grammar was wrong.
The message is now "The key '%s' is not in the map". If the key is not text, it falls back to the key's bytes with %x.
Closes #7988