{{ message }}
NYL-22: Add Contact metadata and webhook parity - #340
Merged
Merged
Conversation
AaronDDM
approved these changes
Aug 27, 2026
AaronDDM
left a comment
AaronDDM
left a comment
Collaborator
There was a problem hiding this comment.
Good morning! Strongest of the four SDK PRs — this is the only one with a real query-serialization test, and covering both create and update builders plus the exact wire names is the right level of detail.
Three notes below, none blocking. Approving.
AaronDDM
approved these changes
Aug 28, 2026
AaronDDM
left a comment
AaronDDM
left a comment
Collaborator
There was a problem hiding this comment.
Good morning! Re-reviewed after 18a4682.
All three items are addressed:
WebhookTriggers.kt— both Contact constants moved to the end, so no published ordinal shifts.WebhooksTests.kt—calendar.createdfixture restored.ContactsTests.kt— email filter case restored, metadata-pair coverage split into its own test.
NylasClientTest covers the metadata_pair=key1:sync_eligible wire shape, the Moshi round-trip test confirms {"metadata":{}} for the clear case while null stays omitted, and the CHANGELOG has an Unreleased section. No new concerns.
Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadata_pairfiltering with query serialization coveragecontact.updatedandcontact.deletedwebhook trigger constants and exact wire-name testsTest plan
./gradlew test lintKotlinwith the repository's Java 8 compiler toolchain (build successful)