{{ message }}
Tw 6413 java sdk fix git reported issue 337 - #338
Merged
Merged
Conversation
AaronDDM
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #337.
The API parses
attendees(events) andany_email(messages/threads/drafts) as asingle comma-delimited string, but the SDK sent them as repeated params
(
attendees=a&attendees=b). The API keeps only the last value, so filtering onmultiple values silently returned wrong, order-dependent results.
Fixed by comma-joining in
NylasClient.addQueryParams, gated on those two paramnames.
event_typeis excluded — the API genuinely supports repeating it.Backward compatible. No signature changes;
attendeesandanyEmailstayList<String>.null, empty, single-element, and already-comma-joined values allproduce the same request as before. Only the multi-value case changes, and it was
already broken.
Also: KDoc now says to pass one address per entry and notes that multiple attendees
match with AND. Changelog updated.
Tests: 7 new cases in
NylasClientTest.QueryParamSerializationTestscapturing thereal outgoing URL. Full suite 536 passing, lint clean.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.