Submodule nvmrc update protocol from git to https - #3839
Conversation
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
ssh is far superior to https; switching would break development use cases. i'm unclear on the problem
No, I don't want to deploy SSH key on a production server if not cìnecessary. |
Usually I have at least 2 branch in my repos: min/prod and develop. In the production I reference submodules using HTTPS (if repos ar public) in develop branch I use SSH to shorten development time. |
|
Fixed the indentation problem, do you think that we can merge the change? |
|
That's a pretty atypical workflow ime. I don't intend to merge this; it should be using ssh. The other thing though is that submodules aren't fetched by default - maybe your git config is doing this? Installing nvm shouldn't fetch the submodule, only development on it should. |
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
sure, this seems like a great improvement. thanks!
2 participants
Using Ansible to clone NVM to one of my server I am getting authentication error due to
fatal: Could not read from remote repository.The error is due to the fact that the submodule is currently set to use GIT protocol and require autentication. I just updated Submodule URL from GIT to HTTPS.
Error: