{{ message }}
[tests] remove double-substitution in assert_ok and assert_not_ok - #3826
Merged
Conversation
Co-authored-by: Андрій Шовкошитний <198119344+enlightened88@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Member
ljharb
marked this pull request as draft
April 23, 2026 17:45
Contributor
Author
|
$( |
Member
|
Can you provide a regression test? |
Contributor
Author
ljharb
approved these changes
Apr 24, 2026
ljharb
left a comment
ljharb
left a comment
Member
There was a problem hiding this comment.
Thanks! I split up the test file and moved it to a place where it'd actually be run.
ljharb
marked this pull request as ready for review
April 24, 2026 17:27
ljharb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed make_echo appending the script body instead of overwriting the shebang, and replaced erroneous command-substitution wrappers in assert_ok/assert_not_ok with direct quoted function calls.