Auth support for NVM_AUTH_HEADER env var by dwelch2344 · Pull Request #3380 · nvm-sh/nvm · GitHub
Skip to content

Auth support for NVM_AUTH_HEADER env var - #3380

Merged
ljharb merged 3 commits into
nvm-sh:masterfrom
dwelch2344:auth_header
Jul 26, 2024
Merged

Auth support for NVM_AUTH_HEADER env var#3380
ljharb merged 3 commits into
nvm-sh:masterfrom
dwelch2344:auth_header

Conversation

@dwelch2344

@dwelch2344 dwelch2344 commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

A simple POC to build from, but wanted to open for feedback on #3366

@dwelch2344 dwelch2344 changed the title [New] Add support for NVM_AUTH_HEADER env var Auth support for NVM_AUTH_HEADER env var Jun 21, 2024

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It'll need some tests ofc.

Comment thread nvm.sh Outdated
Comment thread nvm.sh Outdated
Comment thread nvm.sh Outdated
Comment thread test/fast/Unit tests/nvm_download Outdated
Comment thread nvm.sh Outdated
@dwelch2344
dwelch2344 marked this pull request as ready for review June 28, 2024 15:19
Comment thread test/fast/Unit tests/nvm_download Outdated
Comment thread nvm.sh Outdated
Comment thread nvm.sh Outdated
Comment thread nvm.sh Outdated
@ljharb ljharb added installing node Issues with installing node/io.js versions. feature requests I want a new feature in nvm! labels Jun 29, 2024
@ljharb
ljharb force-pushed the auth_header branch 2 times, most recently from 2bf3f9a to 78e9f45 Compare July 1, 2024 20:53

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ljharb ljharb closed this Jul 4, 2024
@ljharb ljharb reopened this Jul 4, 2024
@ljharb
ljharb force-pushed the auth_header branch 5 times, most recently from 016af9d to 8fcd4ab Compare July 6, 2024 19:13
@ljharb
ljharb force-pushed the auth_header branch 2 times, most recently from 981d19c to 29331ff Compare July 23, 2024 02:17
@ljharb ljharb closed this Jul 26, 2024
@ljharb ljharb reopened this Jul 26, 2024
ljharb and others added 2 commits July 26, 2024 12:04
Closes nvm-sh#3366

Co-authored-by: David Welch <david@davidwelch.co>
Co-authored-by: Andre Kradolfer <narfdre@gmail.com>
@CDIT-BE

CDIT-BE commented Oct 21, 2024

Copy link
Copy Markdown

@ljharb

ljharb commented Oct 21, 2024

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature requests I want a new feature in nvm! installing node Issues with installing node/io.js versions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants