{{ message }}
fix(refactor): remove retired diagnostics API - #506
Open
khaneliman wants to merge 1 commit into
Open
Conversation
Let vim.lsp.buf.code_action populate diagnostics. The vim.lsp.diagnostic API no longer exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove a refactor call to the retired
vim.lsp.diagnosticAPI.Why
nvim-java requires Neovim 0.11.5 or newer. That version no longer provides
vim.lsp.diagnostic.get_line_diagnostics(), so refactor commands fail before sending a code-action request.What changed
vim.lsp.buf.code_action()populate diagnostics through the current API.Testing
nix run nixpkgs#stylua -- --check lua/java-refactor/api/refactor.lua tests/specs/refactor_spec.luanix run nixpkgs#lua51Packages.luacheck -- lua tests/specsnix shell nixpkgs#gnumake -c make test FILE=tests/specs/refactor_spec.lua, 1 test passedRelated Issue(s)
None found.