fix(module): use user `vite` version to merge config by danielroe · Pull Request #1345 · nuxt/test-utils · GitHub
Skip to content

fix(module): use user vite version to merge config#1345

Merged
danielroe merged 1 commit into
mainfrom
deps/vite
Jul 1, 2025
Merged

fix(module): use user vite version to merge config#1345
danielroe merged 1 commit into
mainfrom
deps/vite

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently test/utils has an explicit dependency on vite, as we need to respect the algo for merging vite configuration. But that does unduly bind a particular version of ntu to a certain version of vite (and therefore, perhaps, nuxt).

with the upcoming update to vite v7, this seems an appropriate time to import vite dynamically as-needed, respecting the version of the package that an end user has installed.

@pkg-pr-new

pkg-pr-new Bot commented Jul 1, 2025

Copy link
Copy Markdown

@danielroe danielroe merged commit 737e133 into main Jul 1, 2025
6 checks passed
@danielroe danielroe deleted the deps/vite branch July 1, 2025 11:46
@github-actions github-actions Bot mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant