iframe-proxy

oritwoen · 2026-03-11T18:37:49Z

When a view transition gets aborted (navigation error, app error, or Vue error), the error handlers call abortTransition() which rejects the update callback's promise. This causes transition.finished to reject too, but .then(resetTransitionState) only attached a resolve handler - the derived promise rejected with no catch, producing an unhandled promise rejection warning in the browser console.

Added .catch(resetTransitionState) so rejections run the same idempotent cleanup. The error handlers already deal with the actual error; this just prevents the stray rejection.

Repro: enable experimental.viewTransition, trigger a navigation error (e.g. a middleware that throws) while a view transition is in progress.

bolt-new-by-stackblitz · 2026-03-11T18:37:53Z

pkg-pr-new · 2026-03-11T18:40:05Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@34515

@nuxt/nitro-server

npm i https://pkg.pr.new/@nuxt/nitro-server@34515

nuxt

npm i https://pkg.pr.new/nuxt@34515

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@34515

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@34515

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@34515

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@34515

commit: a15a69c

coderabbitai · 2026-03-11T18:41:27Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 609fea20-4bbc-4290-a610-053559ab182e

📥 Commits

Reviewing files that changed from the base of the PR and between 3373caf and 882706e.

📒 Files selected for processing (1)

packages/nuxt/src/app/plugins/view-transitions.client.ts

Walkthrough

The plugin's view-transition completion handling was modified: the promise chain on transition.finished was changed from using then(resetTransitionState) to catch(() => {}) followed by finally(resetTransitionState). This absorbs any rejection from the transition promise and guarantees resetTransitionState runs regardless of resolution or rejection. No other logic or exported declarations were changed.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main fix: handling rejected promises in view transition abort scenarios, which directly matches the changeset's primary purpose.
Description check	✅ Passed	The description is directly related to the changeset, explaining the problem context, the solution implemented, and how to reproduce the issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

packages/nuxt/src/app/plugins/view-transitions.client.ts (1)
96-96: Consider using .finally() for cleaner cleanup semantics.

The fix correctly addresses the unhandled promise rejection. Since resetTransitionState is idempotent cleanup that should run regardless of outcome, .finally() would be slightly more idiomatic:
-    transition.finished.then(resetTransitionState).catch(resetTransitionState)
+    transition.finished.finally(resetTransitionState)
Any browser supporting document.startViewTransition will support .finally(). This is purely a stylistic preference — the current approach works correctly.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/nuxt/src/app/plugins/view-transitions.client.ts` at line 96, Replace
the promise handling on transition.finished to use .finally() for cleanup:
instead of calling
transition.finished.then(resetTransitionState).catch(resetTransitionState), call
transition.finished.finally(resetTransitionState) so the idempotent cleanup
function resetTransitionState always runs once after the promise settles; locate
the call where transition.finished is used (inside the
document.startViewTransition handling) and update it to
.finally(resetTransitionState).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/nuxt/src/app/plugins/view-transitions.client.ts`:
- Line 96: Replace the promise handling on transition.finished to use .finally()
for cleanup: instead of calling
transition.finished.then(resetTransitionState).catch(resetTransitionState), call
transition.finished.finally(resetTransitionState) so the idempotent cleanup
function resetTransitionState always runs once after the promise settles; locate
the call where transition.finished is used (inside the
document.startViewTransition handling) and update it to
.finally(resetTransitionState).

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8ad53fe9-aa4c-4a7f-9c32-11292cc03dbc

📥 Commits

Reviewing files that changed from the base of the PR and between c0bbb6e and 588c7e5.

📒 Files selected for processing (1)

packages/nuxt/src/app/plugins/view-transitions.client.ts

codspeed · 2026-03-11T18:47:04Z

Merging this PR will improve performance by 14.54%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 19 untouched benchmarks
⏩ 3 skipped benchmarks¹

Performance Changes

_{Comparing oritwoen:fix/view-transition-unhandled-rejection (882706e) with main (10ac237)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Co-authored-by: Daniel Roe <daniel@roe.dev>

fix(nuxt): handle rejected promise in view transition abort

588c7e5

oritwoen requested a review from danielroe as a code owner March 11, 2026 18:37

github-actions Bot added 5.x 🐛 bug Something isn't working as expected labels Mar 11, 2026

coderabbitai Bot reviewed Mar 11, 2026

View reviewed changes

danielroe reviewed Mar 11, 2026

View reviewed changes

Comment thread packages/nuxt/src/app/plugins/view-transitions.client.ts Outdated

refactor(nuxt): use .finally for view transition cleanup

3373caf

danielroe reviewed Mar 11, 2026

View reviewed changes

Comment thread packages/nuxt/src/app/plugins/view-transitions.client.ts Outdated

Update packages/nuxt/src/app/plugins/view-transitions.client.ts

882706e

Co-authored-by: Daniel Roe <daniel@roe.dev>

danielroe approved these changes Mar 11, 2026

View reviewed changes

danielroe enabled auto-merge March 11, 2026 21:57

danielroe added this pull request to the merge queue Mar 11, 2026

Merged via the queue into nuxt:main with commit d5d8ce2 Mar 11, 2026
44 checks passed

github-actions Bot mentioned this pull request Mar 11, 2026

v5.0.0 #34497

Draft

2 of 5 tasks

danielroe added a commit that referenced this pull request Mar 12, 2026

fix(nuxt): handle rejected promise in view transition abort (#34515)

2dc5255

Co-authored-by: Daniel Roe <daniel@roe.dev>

github-actions Bot mentioned this pull request Mar 11, 2026

v4.4.0 #34382

Merged

danielroe added a commit that referenced this pull request Mar 12, 2026

fix(nuxt): handle rejected promise in view transition abort (#34515)

2194e2c

Co-authored-by: Daniel Roe <daniel@roe.dev>

github-actions Bot mentioned this pull request Mar 12, 2026

v3.21.2 #34290

Merged

coderabbitai Bot mentioned this pull request Jul 2, 2026

perf(nuxi): optimise chat composables, caching and navigation nuxt/nuxt.com#2305

Merged

Perdolique mentioned this pull request Jul 9, 2026

Unhandled ViewTransition.ready rejection when a view transition is skipped #35535

Closed

Satin3737 mentioned this pull request Oct 17, 2026

Unhandled rejection of updateCallbackDone when a navigation with a view transition fails #36626

Open

0xgdr mentioned this pull request Oct 19, 2026

fix(nuxt): handle rejected updateCallbackDone of aborted view transition #36639

Open

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

fix(nuxt): handle rejected promise in view transition abort - #34515

fix(nuxt): handle rejected promise in view transition abort#34515
danielroe merged 3 commits into
nuxt:mainfrom
oritwoen:fix/view-transition-unhandled-rejection

oritwoen commented Mar 11, 2026

Uh oh!

bolt-new-by-stackblitz Bot commented Mar 11, 2026

Uh oh!

pkg-pr-new Bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

codspeed Bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

oritwoen commented Mar 11, 2026

Uh oh!

bolt-new-by-stackblitz Bot commented Mar 11, 2026

Uh oh!

pkg-pr-new Bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed Bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 14.54%

Performance Changes

Footnotes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pkg-pr-new Bot commented Mar 11, 2026 •

edited

Loading

coderabbitai Bot commented Mar 11, 2026 •

edited

Loading

codspeed Bot commented Mar 11, 2026 •

edited

Loading