{{ message }}
BUG: Use auxdata in (arg)sort strided_loops#31670
Merged
Merged
Conversation
MaanasArora
added
00 - Bug
09 - Backport-Candidate
seberg
approved these changes
Jun 18, 2026
seberg
left a comment
seberg
left a comment
Member
There was a problem hiding this comment.
Thanks, clearly right. I'll accept that a test for this is tedious since it is pretty much unused in practice.
charris
pushed a commit
that referenced
this pull request
Jun 19, 2026
As Arraymethods `auxdata` clearly needs to be forwarded (even it in practice it is always NULL and likely to not be used much -- it would be theoretically for structured dtype specialized sorts).
charris
added a commit
that referenced
this pull request
Jun 19, 2026
BUG: Use `auxdata` in (arg)sort `strided_loop`s (#31670)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was somehow missed back in #29737, sorry :/ I've marked this for backport as it's a clear bug in the user dtype implementation for slots.
AI Disclosure
No AI tools used.