{{ message }}
MAINT: simplify view implementations in MaskedArray and recarray.#31317
Open
mhvk wants to merge 1 commit intonumpy:mainfrom
Open
MAINT: simplify view implementations in MaskedArray and recarray.#31317mhvk wants to merge 1 commit intonumpy:mainfrom
mhvk wants to merge 1 commit intonumpy:mainfrom
Conversation
Possible after the changes in ndarray.view().
mhvk
commented
Apr 23, 2026
Contributor
Author
There was a problem hiding this comment.
This protection of the mask is not actually needed, as __array_finalize__ already ensures it is a view (in fact, a double view given the reshape).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are possible after the changes in
ndarray.view()in #31234 (and taken from the initial version of #31271). Also used the occasion to dosuper().viewrather than callingndarray.view(which predates the introduction ofsuperin python...).No AI used.