{{ message }}
BUG: Fix segfault in nditer.multi_index when __getitem__ raises#31314
Merged
ngoldbaum merged 2 commits intonumpy:mainfrom Apr 23, 2026
Merged
BUG: Fix segfault in nditer.multi_index when __getitem__ raises#31314ngoldbaum merged 2 commits intonumpy:mainfrom
ngoldbaum merged 2 commits intonumpy:mainfrom
Conversation
Check return value of PySequence_GetItem before use to avoid dereferencing NULL and ensure Python exceptions are propagated.
Member
Member
|
Thanks @Breno-Favaretto. Please feel free to send in more fixes like this, if you feel like it. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR summary
Add a NULL check for PySequence_GetItem in the multi_index setter to prevent
segmentation faults when getitem raises an exception.
As reported in:
https://gist.github.com/devdanzin/ccc2d9553ca1c90ab1835362ee21a40a#reproducer-3-nditermulti_index-segfault-with-raising-sequence
(discussed in #31046)
Reproduce error:
Actual behavior:
Expected behavior:
First time committer introduction
AI Disclosure
AI tools were used to assist with English writing and phrasing in this PR.The technical analysis, debugging, and code changes were performed and verified manually.