{{ message }}
BUG: prevent crash when setting array flags with non-ASCII strings#31297
Closed
Breno-Favaretto wants to merge 1 commit intonumpy:mainfrom
Closed
BUG: prevent crash when setting array flags with non-ASCII strings#31297Breno-Favaretto wants to merge 1 commit intonumpy:mainfrom
Breno-Favaretto wants to merge 1 commit intonumpy:mainfrom
Conversation
jorenham
reviewed
Apr 21, 2026
Member
There was a problem hiding this comment.
nitpick:
Suggested change
| if (tmp_str == NULL){ | |
| if (tmp_str == NULL) { |
Member
|
oh, actually, this looks like it's a duplicate of #31257 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Fix a crash when using non-ASCII keys in:As reported in:
https://gist.github.com/devdanzin/ccc2d9553ca1c90ab1835362ee21a40a#reproducer-2-arrflags-segfault-on-non-ascii-key
(discussed in #31046)
Using non-ASCII characters as keys could lead to a segmentation fault due to
unsafe handling of Unicode input in the C implementation.
Reproducer
Previous behavior
New behavior
First time committer introduction
AI Disclosure
AI was used to help me understand the English better and to assist in writing this message. All code and debugging were done by me.