Fix `os.path.commonprefix` deprecation by hugovk · Pull Request #30898 · numpy/numpy · GitHub
Skip to content

Fix os.path.commonprefix deprecation#30898

Merged
mattip merged 1 commit into
numpy:mainfrom
hugovk:fix-os-path-commonprefix-deprecation
Mar 1, 2026
Merged

Fix os.path.commonprefix deprecation#30898
mattip merged 1 commit into
numpy:mainfrom
hugovk:fix-os-path-commonprefix-deprecation

Conversation

@hugovk

@hugovk hugovk commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

@ngoldbaum

Copy link
Copy Markdown
Member

@hugovk

hugovk commented Feb 28, 2026

Copy link
Copy Markdown
Contributor Author

Should we delete the c_coverage directory?

https://github.com/numpy/numpy/tree/main/tools/c_coverage

@mattip

mattip commented Mar 1, 2026

Copy link
Copy Markdown
Member

I would like to have a spin coverage command that runs the tests including python and c level coverage. Wouldn't removing the directory would make that task harder?

@mattip

mattip commented Mar 1, 2026

Copy link
Copy Markdown
Member

See also #26932, #19853.

@ngoldbaum

Copy link
Copy Markdown
Member

Ah good, I missed that. If you think this code will be useful for future plans we should merge this.

@mattip mattip merged commit fe7a927 into numpy:main Mar 1, 2026
73 checks passed
@mattip

mattip commented Mar 1, 2026

Copy link
Copy Markdown
Member

@hugovk hugovk deleted the fix-os-path-commonprefix-deprecation branch March 1, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants