Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
ENH, API: New sorting slots for DType API #29737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
f4627e7
ENH, API: New sorting slots for DType API
MaanasArora 01c6545
DOC: Add sorting context structures and functions to DType API docume…
MaanasArora c613e37
DOC: Fix type signature syntax
MaanasArora 7035208
DOC: Update data pointer type in sorting function signatures
MaanasArora a0393aa
DOC: Fix incorrect argsort function name
MaanasArora 8996d3d
DOC: Fix formatting of function signature for PyArray_SortFuncWithCon…
MaanasArora 50d3604
ENH: Initialize moving to an arraymethod table for user dtype sorts
MaanasArora 9a421f3
ENH: Initialize PyArrayMethod_Context to zero in sorting functions
MaanasArora 7d55810
ENH: Add stable sort option to context in user sorts
MaanasArora 32191f2
DOC: Remove deprecated references from DType API sorting documentation
MaanasArora 1d7cea9
ENH: Refactor sorting parameters to use NPY_SORTKIND in PyArrayMethod…
MaanasArora d549d81
ENH: Remove unnecessary blank line in NPY_DType_Slots structure
MaanasArora e8e258e
ENH: Simplify axis check in PyArray_ArgSort
MaanasArora 9a2b9ee
REF: Simplify PyArray_(Arg)Sort loop discovery logic
MaanasArora ff29e9a
BUG: Add missing breaks in loop discovery in sorts
MaanasArora 7dd98d5
BUG: Simplify context initialization in PyArray_Sort and PyArray_ArgSort
MaanasArora bb46a1c
BUG: Fix dangling pointer to context in PyArray_(Arg)Sort
MaanasArora 3988f08
BUG: Fix dangling context pointer in PyArray_(Arg)Sort
MaanasArora c20c4bb
REF: Update sorting implementation to use new generalized array metho…
MaanasArora 43965c4
ENH: Use dtype slots for sort and argsort arraymethods
MaanasArora b22d4c4
STYLE: Add back blank line in methods.h
MaanasArora 86adfd6
REF: Simplify conditional logic in PyArray_Sort and PyArray_ArgSort
MaanasArora 5d888d8
BUG: Add error handling for strided loop retrieval in PyArray_(Arg)Sort
MaanasArora c8c9845
ENH: Fill out context and strides in sort strided loop calls
MaanasArora 566ddf1
ENH: Add correct number of descriptors and strides in sorting loops
MaanasArora 36c59b7
BUG: Correct descriptors and strides in argsort implementation
MaanasArora 5265524
ENH: If-case parameters field in PyArrayMethod_Context
MaanasArora 4ad0b14
REF: Initialize PyArrayMethod_Context structure directly for sorting …
MaanasArora adb8292
ENH: Pass auxdata to dtype sorts
MaanasArora 3a0c3c9
ENH: Update stride calculation for sorting to use item size
MaanasArora 9eba6dc
ENH: Refactor context initialization and descriptor resolution in sor…
MaanasArora 18e5a3d
ENH: Implement sorting and argsorting methods for scaled float dtype
MaanasArora 433d203
DOC: Add comment to clarify that we ignore `view_offset`
MaanasArora 9b4f202
ENH: Free auxdata and decref descriptors in sorting functions
MaanasArora 9da1a1c
DOC: Add comments to clarify that method flags are ignored in sorting…
MaanasArora 1d4699d
ENH: Add scaled float tests for sorting and argsorting with scaled an…
MaanasArora eab3bac
TST: Update scaled float argsort test to stride array
MaanasArora 9f1ae16
STYLE: Fix formatting in sfloat test_sort
MaanasArora 2cb4e5f
BUG: Update sorting functions to check for sort method in cleanup ins…
MaanasArora f67f5b3
REF: Fix scope for sort contexts
MaanasArora 52ff04b
REF: Initialize sorting context only if taken
MaanasArora 255fe0f
DOC: Add parameters member to PyArrayMethod_Context for loop paramete…
MaanasArora 2153628
BUG: Move declaration of loop_descrs array in PyArray_ArgSort
MaanasArora 4a0f769
DOC: Add comment clarifying arraymethod context parameters
MaanasArora 6954cf9
DOC: Clarify description of parameters member in PyArrayMethod_Context
MaanasArora a2dfdef
REF: Use existing variable to simplify NPY_DTYPE macro
MaanasArora ce793cc
BUG: Add missing output decref in PyArray_ArgSort
MaanasArora 7e767e5
BUG: Add assertions to validate parameters in sorting functions of sc…
MaanasArora f3c1e04
REF: Simplify argument passing by removing unnecessary dimensions and…
MaanasArora e0f923d
BUG: Fix castinfo changes
MaanasArora 1eee5a4
TST: assert exact stride values in sfloat sorts
MaanasArora 5a66e6e
TST: assert exact stride values in sfloat sorts
MaanasArora 7f11d40
DOC: move versionchanged in ArrayMethod_Context
MaanasArora 01a9515
BUG: Fix stride initialization in _new_sortlike and ensure proper dec…
MaanasArora 912fdbd
BUG: Correct dimension and stride initializations in sorting
MaanasArora a87a0c2
BUG: Fix strides initialization in sorting
MaanasArora 56bf123
DOC: clarify function level in parameters for PyArrayMethod_Context
MaanasArora c94e02f
REF: initialize slots in-line for sfloat sorts
MaanasArora 3a2cbcc
BUG: Remove incorrect dimension assertions in sorting loops
MaanasArora ee17e43
BUG: Correct size to sizeof
MaanasArora 477c705
STYLE: revert newline deletion
MaanasArora 7b9a2bc
STYLE: remove trailing whitespace
MaanasArora 2ea19e7
STYLE: revert delete newline
MaanasArora e3a8bba
BUG: Fix incorrect stride assignment in _new_sortlike function
MaanasArora 2b5c383
STYLE: Remove unnecessary whitespace
MaanasArora d23025f
DOC: Improve comment
MaanasArora 179c617
REF: Remove first branch in resolve_descriptors for sfloat sorts
MaanasArora abf4358
TST: Add reverse sorting test for non-aligned arrays in sfloat sort t…
MaanasArora d8f8b51
DOC: Add TODO comments for future registration method in sfloat_init_…
MaanasArora 64ca9e2
ENH: Perform descriptor handling in sorting array method for byte order
MaanasArora c93e39b
DOC: Remove redundant versionchanged note in types-and-structures.rst
MaanasArora 1fe943d
TST: Add stable and unstable sorting tests for sfloat arrays
MaanasArora 7be1c22
ENH: Update stride assertions in sfloat_default_sort_loop for improve…
MaanasArora cb285e9
ENH: Add stride assertions in sfloat_default_argsort_loop for improve…
MaanasArora adb0fc8
ENH: Change descriptor handling in sfloat_sort_resolve_descriptors an…
MaanasArora 8fe7207
ENH: Manage reference counting for argsort method in sfloat_init_sort…
MaanasArora f0ad94c
ENH: Add assertion in sfloat_sort_resolve_descriptors to validate des…
MaanasArora 98e13cd
ENH: Add assertion in sfloat_argsort_resolve_descriptors to validate …
MaanasArora 93abb18
ENH: Move error handling to sfloat_sort_get_loop and sfloat_argsort_g…
MaanasArora dd4e914
ENH: Manage reference counting for sort method in sfloat_init_sort to…
MaanasArora b6e3085
REF: Clarify stride calculation in PyArray_Sort and PyArray_ArgSort
MaanasArora 5c6a76a
ENH: Add method flag handling in sorting methods to check for GIL
MaanasArora b222adf
REF: Simplify descr element size retrieval in PyArray_Sort and PyArra…
MaanasArora 6c59c73
BUG: Replace NULL return with goto fail in PyArray_ArgSort for error …
MaanasArora a8e95e6
REF: Assert instead of handling non-native byteorder in sfloat sorts
MaanasArora e8e9abf
BUG: Initialize return value to NULL in PyArray_ArgSort for error han…
MaanasArora f7029b3
REF: Remove descr-specific thread release in favor of pyapi flag in s…
MaanasArora 1a78671
BUG: Fix needcopy logic in _new_sortlike and _new_argsortlike functions
MaanasArora 9671d42
BUG: Remove unnecessary NULL check for odescr in PyArray_ArgSort
MaanasArora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.

Uh oh!
There was an error while loading. Please reload this page.