DEP: Remove `normed=` keyword argument from histograms by seberg · Pull Request #21645 · numpy/numpy · GitHub
Skip to content

DEP: Remove normed= keyword argument from histograms#21645

Merged
charris merged 3 commits into
numpy:mainfrom
seberg:histogram-remove-normed
Jun 3, 2022
Merged

DEP: Remove normed= keyword argument from histograms#21645
charris merged 3 commits into
numpy:mainfrom
seberg:histogram-remove-normed

Conversation

@seberg

@seberg seberg commented Jun 2, 2022

Copy link
Copy Markdown
Member

The normed keyword argument has been deprecated for a long time.
This removes it, replacing its position with the new density
argument.

The normed keyword argument has been deprecated for a long time.
This removes it, replacing its position with the new density
argument.
@seberg seberg changed the title DEP: Remove normed= keyword argument from histogroms DEP: Remove normed= keyword argument from histograms Jun 2, 2022
@seberg seberg added the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Jun 2, 2022
@seberg seberg removed the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Jun 2, 2022
@seberg

seberg commented Jun 2, 2022

Copy link
Copy Markdown
Member Author

@seberg seberg force-pushed the histogram-remove-normed branch from 8768a92 to 40bd14d Compare June 2, 2022 19:34
@rossbar

rossbar commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

If anyone has any concerns about that, we could potentially escalate or make the release note a bit clearer on that front.

I think the only case where the behavior would change would be if a user called the function with positional args and non-uniform bins, in which case the previous behavior was buggy and the new behavior is correct, so this seems fine to me 👍

@charris charris merged commit c994325 into numpy:main Jun 3, 2022
@charris

charris commented Jun 3, 2022

Copy link
Copy Markdown
Member

Thanks Sebastian.

@tacaswell

Copy link
Copy Markdown
Contributor

The 1D case was well documented + warnning, but the 2D and nd cases appear to only have been documented as deprecated by reference and never warned.

@seberg

seberg commented Mar 18, 2024

Copy link
Copy Markdown
Member Author

Hmmm, true, not sure I really realized this when doing this. Do you think we should "go back" to a deprecation for those?

@tacaswell

Copy link
Copy Markdown
Contributor

I got back-channel grumpy users claiming "no one in Python cares about back-compatibility" over this so maybe.

However, given we are now over a year and 2 minor versions past this I'm not sure how many people who will be bit by this are left and of those how many won't be bit by it anyway (if they are lagging versions they likely won't jump to the newest version but go to 1.24 eventually).

@seberg

seberg commented Mar 18, 2024

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants