{{ message }}
Repository navigation
fix: oidc visibility check for provenance - #8467
Merged
Merged
Conversation
wraithgar
reviewed
Jul 29, 2025
wraithgar
reviewed
Jul 29, 2025
Co-authored-by: Gar <gar+gh@danger.computer>
Co-authored-by: Gar <gar+gh@danger.computer>
wraithgar
approved these changes
Jul 30, 2025
Merged
This was referenced Aug 25, 2026
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When someone with a public repository and a private package attempts to publish with OIDC, the publish command will fail because provenance is enabled, there is currently no visibility check before auto enabling provenance.
This is a very rare edge case, but it's still incorrect. OIDC will always gracefully fail, but provenance does not.