fix: correctly handle scenario where prefix is the cwd by owlstronaut · Pull Request #8269 · npm/cli · GitHub
Skip to content

fix: correctly handle scenario where prefix is the cwd#8269

Merged
wraithgar merged 1 commit intolatestfrom
6960_fix_local_directory_prefix_usage
May 5, 2025
Merged

fix: correctly handle scenario where prefix is the cwd#8269
wraithgar merged 1 commit intolatestfrom
6960_fix_local_directory_prefix_usage

Conversation

@owlstronaut
Copy link
Copy Markdown
Contributor

@owlstronaut owlstronaut commented May 2, 2025

closes #6960

related #7208

resolves feedback from #7208 (comment) and #7208 (review)

Manually verified the fix on windows

@owlstronaut owlstronaut force-pushed the 6960_fix_local_directory_prefix_usage branch from bc7a7b5 to 48afa7b Compare May 2, 2025 21:02
@owlstronaut owlstronaut marked this pull request as ready for review May 2, 2025 21:03
@owlstronaut owlstronaut requested a review from a team as a code owner May 2, 2025 21:03
@owlstronaut owlstronaut force-pushed the 6960_fix_local_directory_prefix_usage branch from 48afa7b to ef0f993 Compare May 2, 2025 21:05
@owlstronaut owlstronaut changed the title 6960 fix local directory prefix usage fix: issue-6960 Correctly handle scenario where prefix is the CWD May 2, 2025
@wraithgar wraithgar changed the title fix: issue-6960 Correctly handle scenario where prefix is the CWD fix: correctly handle scenario where prefix is the cwd May 5, 2025
@wraithgar wraithgar merged commit 78b5a6f into latest May 5, 2025
24 checks passed
@wraithgar wraithgar deleted the 6960_fix_local_directory_prefix_usage branch May 5, 2025 14:26
@github-actions github-actions Bot mentioned this pull request Apr 23, 2025
magicsunday added a commit to magicsunday/webtrees-fan-chart that referenced this pull request Apr 19, 2026
The 'timeout 900 npm ci' wrapper introduced in round-3 has caused two
real release-pipeline failures, both for npm signal-handling reasons:

1. First retry hung 40+ min on cold-cache install — the timeout did
   fire (busybox SIGTERM) but npm's child install (node-linux-x64
   postinstall) survived in a separate process group. Manual kill -9
   needed.
2. Second retry failed within ~2 min with 'npm error Exit handler
   never called!' — npm 11 self-bug triggered by the timeout wrapper
   interacting with npm's internal exit handlers (npm/cli#8269+).

Round-4 review predicted that the timeout was 'judgment call, skip' —
real-world experience confirmed it. The timeout protects against an
indefinite GitHub-down hang that has never happened in practice.
Manual intervention on a hang is acceptable; a broken release
pipeline that publishes nothing is not.

Removing the wrapper from both build-js-fresh and the CI install
step. NPM_CI_TIMEOUT variable also removed (no longer referenced).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] npm install --prefix="$PWD" adds invalid dependency to package.json

3 participants