{{ message }}
fix: correctly handle scenario where prefix is the cwd#8269
Merged
Conversation
bc7a7b5 to
48afa7b
Compare
48afa7b to
ef0f993
Compare
wraithgar
approved these changes
May 5, 2025
Merged
This was referenced May 13, 2025
magicsunday
added a commit
to magicsunday/webtrees-fan-chart
that referenced
this pull request
Apr 19, 2026
The 'timeout 900 npm ci' wrapper introduced in round-3 has caused two real release-pipeline failures, both for npm signal-handling reasons: 1. First retry hung 40+ min on cold-cache install — the timeout did fire (busybox SIGTERM) but npm's child install (node-linux-x64 postinstall) survived in a separate process group. Manual kill -9 needed. 2. Second retry failed within ~2 min with 'npm error Exit handler never called!' — npm 11 self-bug triggered by the timeout wrapper interacting with npm's internal exit handlers (npm/cli#8269+). Round-4 review predicted that the timeout was 'judgment call, skip' — real-world experience confirmed it. The timeout protects against an indefinite GitHub-down hang that has never happened in practice. Manual intervention on a hang is acceptable; a broken release pipeline that publishes nothing is not. Removing the wrapper from both build-js-fresh and the CI install step. NPM_CI_TIMEOUT variable also removed (no longer referenced).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

closes #6960
related #7208
resolves feedback from #7208 (comment) and #7208 (review)
Manually verified the fix on windows