chore: stop publish smoke from check git clean by reggi · Pull Request #8058 · npm/cli · GitHub
Skip to content

chore: stop publish smoke from check git clean - #8058

Merged
wraithgar merged 10 commits into
latestfrom
reggi/smoke-preid3
Jan 27, 2025
Merged

wraithgar merged 10 commits into
latestfrom
reggi/smoke-preid3

Conversation

@reggi

@reggi reggi commented Jan 22, 2025 •

Copy link
Copy Markdown
Contributor

Im a big proponent of scripts working the same way in ci as they would locally. and that we should be able to run anything the ci does locally. The publish script is used to publish npm and ws packages, but also within a series of smoke tests. Making the flags clear it's either one of the two paths was my goal.

@reggi
reggi requested a review from a team as a code owner January 22, 2025 20:46
@reggi

reggi commented Jan 24, 2025

Copy link
Copy Markdown
Contributor Author

Comment thread scripts/publish.js
@wraithgar
wraithgar merged commit 6d0f46e into latest Jan 27, 2025
@wraithgar
wraithgar deleted the reggi/smoke-preid3 branch January 27, 2025 15:59
@github-actions github-actions Bot mentioned this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants