{{ message }}
Conversation
hashtagchris
commented
Nov 19, 2024
Contributor
Author
There was a problem hiding this comment.
I think the types repo may have been manually excluded the last time this file was updated, unless the repo was recently tagged npm-cli. But leaving it in doesn't change the dependency graph.
Member
There was a problem hiding this comment.
It wasn't tagged before. It's not in the cli so it won't have an effect outside this file.
reggi
previously approved these changes
Nov 20, 2024
Member
|
Gonna have to rebase now that #7911 is merged |
This comment was marked as spam.
This comment was marked as spam.
hashtagchris
force-pushed
the
fix-which-dep
branch
from
1f619f1 to
47b9c11
Compare
wraithgar
changed the title
which to dependency graph
Member
wraithgar
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the list of the cli repos, as its been a while. And fix
which's association with its repo.References
https://github.com/npm/cli/pull/7911/files#r1848890847 - I remembered that
whichhas a circular dependency with@npmcli/eslint-configif you count devDependencies as well, and noticedwhichwasn't listed.