{{ message }}
Repository navigation
fix: ignore implicit workspaces when running version - #10147
Open
Brytoxx021 wants to merge 1 commit into
Open
Brytoxx021 wants to merge 1 commit into
Brytoxx021 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
Prevent
npm versionrun from inside a workspace directory from implicitly operating on every workspace in the monorepo.Previously, an implicit workspace caused
npm versionto callchangeWorkspaces(), which enumerated and read all workspacepackage.jsonfiles. When version commands run concurrently across many workspaces, this can race with another process writing a manifest and cause invalid or emptypackage.jsonerrors.This change makes
npm versionhandle the current workspace only unless--workspaceor--workspacesis explicitly provided. It also adds regression coverage for this behavior.References
Fixes #<número-del-issue>
References