{{ message }}
Repository navigation
Conversation
Reading an interval with months as TimeSpan throws, since a month has no fixed length, but the check was months > 0, so '-1 month' read silently as TimeSpan.Zero. Check months != 0, as DurationConverter in the NodaTime plugin already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Reading an interval that has months as a
TimeSpanthrowsInvalidCastException, because a month has no fixed length (#4599). The check inTimeSpanIntervalConverter.Readismonths > 0, though, so a negative month count gets past it and the months are dropped:This changes the check to
months != 0, which is whatDurationConverterin Npgsql.NodaTime already does for the same case.Interval_with_negative_months_cannot_read_as_TimeSpansits next to the existingInterval_with_months_cannot_read_as_TimeSpanand fails without the fix. TheDateTimeTestsand NodaTime tests pass against PostgreSQL 17 (155).Found with the pengdows ADO.NET conformance suite, whose type-fidelity tests round-trip each type's values through every driver. Npgsql 4 and 5 read
-1 monthas -30 days; 6 through currentmainread it as zero.🤖 Generated with Claude Code