"portIsFree" function's "timeout" parameter value increased to solve issues #48, #54 and #70#73
Conversation
In windows, assigning a port may take a little longer than previously assumed value of 2000ms. I am using Windows 10 1903 64bit, and it takes about 3000ms to initialize a port. I increased the timeout to some higher value (9999ms) to give a little more space to Windows to initialize a port to use with the app. This patch probably solves issues nodejs#48, nodejs#54 and nodejs#70
I tried different values and the code gets the port earlier if it is available, so adding a check for OS is not necessary. I agree commenting inside the code could be useful, I couldn't decide if I should. 9999ms is seemed logical as all other numbers would be random values just like the originally assumed 2000ms. |
Hope you or someone with enough knowledge finds some time to work on it. For now, at least those that can access code can change the value just like I did. I am new to this area of coding, maybe in few months I can help on that too. |
3 participants
In windows, assigning a port may take a little longer than previously assumed value of 2000ms.
I am using Windows 10 1903 64bit, and it takes about 3000ms to initialize a port.
I increased the timeout to some higher value (9999ms) to give a little more space to Windows to initialize a port to use with the app.
This patch probably solves issues #48, #54 and #70