test: GitHub Actions add Windows to the testing by cclauss · Pull Request #1996 · nodejs/node-gyp · GitHub
Skip to content

test: GitHub Actions add Windows to the testing#1996

Merged
gengjiawen merged 3 commits into
masterfrom
GitHub-Actions-add-Windows
Dec 29, 2019
Merged

test: GitHub Actions add Windows to the testing#1996
gengjiawen merged 3 commits into
masterfrom
GitHub-Actions-add-Windows

Conversation

@cclauss

@cclauss cclauss commented Dec 16, 2019

Copy link
Copy Markdown
Contributor

@joaocgreis This might be of interest to you.

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

gengjiawen
gengjiawen requested changes Dec 18, 2019
View reviewed changes

@gengjiawen gengjiawen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows test still failed

@cclauss

cclauss commented Dec 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@joaocgreis

joaocgreis commented Dec 29, 2019

Copy link
Copy Markdown
Member

@cclauss isn't this similar to what happened in Travis, the VS version is more recent than the one supported by our gyp version? If this is the case, a good way to fix is to set the MSVS variables similarly to Travis:

node-gyp/.travis.yml

Line 106 in 5a729e8

- GYP_MSVS_VERSION=2015 GYP_MSVS_OVERRIDE_PATH="C:\\Dummy" python -m pytest

@cclauss

cclauss commented Dec 29, 2019

Copy link
Copy Markdown
Contributor Author

Powershell says The term 'GYP_MSVS_VERSION=2015' is not recognized as the name of a cmdlet, function, script file, or operable program.

@cclauss

cclauss commented Dec 29, 2019

Copy link
Copy Markdown
Contributor Author

@gengjiawen gengjiawen merged commit 31ecc84 into master Dec 29, 2019
@gengjiawen gengjiawen deleted the GitHub-Actions-add-Windows branch December 29, 2019 07:43
rvagg pushed a commit that referenced this pull request Jan 3, 2020
@cclauss @rvagg
test: add Windows to GitHub Actions testing (#1996)
bc509c5 
PR-URL: #1996
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This was referenced Jan 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees

@joaocgreis joaocgreis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cclauss @joaocgreis @gengjiawen