travis: add Windows + Python 3.8 to the mix by rvagg · Pull Request #1921 · nodejs/node-gyp · GitHub
Skip to content

travis: add Windows + Python 3.8 to the mix#1921

Closed
rvagg wants to merge 1 commit into
masterfrom
rvagg/python3.8
Closed

travis: add Windows + Python 3.8 to the mix#1921
rvagg wants to merge 1 commit into
masterfrom
rvagg/python3.8

Conversation

@rvagg

@rvagg rvagg commented Oct 15, 2019

Copy link
Copy Markdown
Member

Windows Python 3 tests are currently failing in travis because choco has switched python to 3.8 but we're setting the PATH for 3.7. So I've fixed the 3.7 tests to the last 3.7 version and introduced a 3.8 test for Windows.

Python 3.8 isn't currently available on the other platforms, easily anyway, so they're not added in this.

@rvagg rvagg requested review from cclauss and joaocgreis October 15, 2019 09:17

@cclauss cclauss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks.

@cclauss cclauss added the Python label Oct 15, 2019
@cclauss

cclauss commented Oct 15, 2019

Copy link
Copy Markdown
Contributor

@joaocgreis joaocgreis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

joaocgreis pushed a commit that referenced this pull request Oct 16, 2019
PR-URL: #1921
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: João Reis <reis@janeasystems.com>
@joaocgreis

Copy link
Copy Markdown
Member

@joaocgreis joaocgreis closed this Oct 16, 2019
@rvagg rvagg deleted the rvagg/python3.8 branch October 16, 2019 03:16
rvagg added a commit that referenced this pull request Nov 18, 2019
PR-URL: #1921
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants