{{ message }}
test: configure proper devDir for invoking configure()#1796
Closed
rvagg wants to merge 2 commits into
Closed
Conversation
Member
Member
Author
|
@richardlau maybe not, maybe I'll add one to test-download.js which mocks it all out I think. |
Member
Another way to check would be to see if coverage drops after this PR (now we're using |
rvagg
force-pushed
the
rvagg/cache-dir-for-python-test
branch
from
9b3f6d0 to
ee46c5c
Compare
rvagg
force-pushed
the
rvagg/cache-dir-for-python-test
branch
from
ee46c5c to
c3dfcec
Compare
Member
Author
|
I've rebased this and added a whole new test that downloads headers and verifies contents. @nodejs/node-gyp ptal. |
rvagg
force-pushed
the
rvagg/cache-dir-for-python-test
branch
from
c3dfcec to
43fa2df
Compare
richardlau
reviewed
Nov 7, 2019
richardlau
approved these changes
Nov 8, 2019
test/test-configure-python.js downloads a fresh set of headers to the package directory each time. By setting to the default global cache dir we get to re-use cached headers and skip the download step. PR-URL: #1796 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #1796 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg
force-pushed
the
rvagg/cache-dir-for-python-test
branch
from
43fa2df to
0670e51
Compare
Member
Author
rvagg
added a commit
that referenced
this pull request
Nov 18, 2019
test/test-configure-python.js downloads a fresh set of headers to the package directory each time. By setting to the default global cache dir we get to re-use cached headers and skip the download step. PR-URL: #1796 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg
added a commit
that referenced
this pull request
Nov 18, 2019
PR-URL: #1796 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/test-configure-python.js downloads a fresh set of headers to the package directory each time. By setting to the default global cache dir we get to re-use cached headers and skip the download step. Speeds up tests and prevents the creation of a new directory with headers in it in the package root each test run.