{{ message }}
Repository navigation
fix: resolve Symbol::For overload ambiguity - #1742
Merged
legendecas merged 5 commits intoAug 10, 2026
Merged
Conversation
Signed-off-by: umuoy1 <burningdian@gmail.com>
legendecas
reviewed
Aug 8, 2026
Signed-off-by: umuoy1 <burningdian@gmail.com>
Signed-off-by: umuoy1 <burningdian@gmail.com>
legendecas
reviewed
Aug 9, 2026
Signed-off-by: umuoy1 <burningdian@gmail.com>
legendecas
reviewed
Aug 9, 2026
Signed-off-by: umuoy1 <burningdian@gmail.com>
legendecas
approved these changes
Aug 10, 2026
github-project-automation
Bot
moved this from Need Triage
to Done
in Node-API Team Project
Merged
dadezzz
pushed a commit
to dadezzz/events-cash-register
that referenced
this pull request
Aug 16, 2026
![Renovate [bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [node-addon-api](https://github.com/nodejs/node-addon-api) | [`8.9.1` → `8.9.2`](https://renovatebot.com/diffs/npm/node-addon-api/8.9.1/8.9.2) |  |  | --- ### Release Notes <details> <summary>nodejs/node-addon-api (node-addon-api)</summary> ### [`v8.9.2`](https://github.com/nodejs/node-addon-api/blob/HEAD/CHANGELOG.md#892-2026-08-10) [Compare Source](nodejs/node-addon-api@v8.9.1...v8.9.2) ##### Bug Fixes - resolve Symbol::For overload ambiguity ([#​1742](nodejs/node-addon-api#1742)) ([13c854a](nodejs/node-addon-api@13c854a)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xNy4xIiwidXBkYXRlZEluVmVyIjoiNDQuMTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbol::Foran ambiguous for types that can convert to bothstd::stringandstd::string_view.Instead of removing the existing
std::stringoverload, this keep it so string-only wrappers continue to work and adds a constrained forwarding overload for the ambiguous case. Calls that already have a unique best match keep using the existing overloads.Fixes #1741