{{ message }}
Repository navigation
fix: missing napi_delete_reference on ObjectWrap ref - #1607
Merged
Merged
Conversation
legendecas
marked this pull request as draft
October 31, 2024 11:01
legendecas
force-pushed
the
remove_wrap
branch
from
October 31, 2024 11:02
388dd68 to
44a9852
Compare
legendecas
force-pushed
the
remove_wrap
branch
from
October 31, 2024 11:38
44a9852 to
4e05944
Compare
legendecas
marked this pull request as ready for review
October 31, 2024 11:56
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://nodejs.org/api/n-api.html#napi_wrap, the
napi_referencereturned fromnapi_wrapshould be deleted withnapi_delete_reference. In node-addon-api, for anObjectWrap, this is done with~Referencedestructor when the_refis notnullptr.To prevent
~ObjectWrapfrom creating a handle during finalization, add a new flag to guard on it, instead of nullify_ref.Submitted nodejs/node#55620 to allow
napi_delete_referencebeen immediately invoked in annode_api_basic_finalizer.Fixes #1602