src: add Object::TypeTag, Object::CheckTypeTag by KevinEady · Pull Request #1261 · nodejs/node-addon-api · GitHub
Skip to content

src: add Object::TypeTag, Object::CheckTypeTag#1261

Closed
KevinEady wants to merge 4 commits intonodejs:mainfrom
KevinEady:add-type-tag-methods
Closed

src: add Object::TypeTag, Object::CheckTypeTag#1261
KevinEady wants to merge 4 commits intonodejs:mainfrom
KevinEady:add-type-tag-methods

Conversation

@KevinEady
Copy link
Copy Markdown
Contributor

Adds support for napi_type_tag_object via Object::TypeTag and napi_check_object_type_tag via Object::CheckTypeTag.

Closes: #1260

@KevinEady
Copy link
Copy Markdown
Contributor Author

KevinEady commented Jan 2, 2023

Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Jan 13, 2023
PR-URL: #1261
Reviewed-By: Michael Dawson <midawson@redhat.com
@mhdawson
Copy link
Copy Markdown
Member

@mhdawson mhdawson closed this Jan 13, 2023
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
PR-URL: nodejs/node-addon-api#1261
Reviewed-By: Michael Dawson <midawson@redhat.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing napi_type_tag_object?

2 participants