deps: upgrade npm to 3.10.8 by zkat · Pull Request #8706 · nodejs/node · GitHub
Skip to content

deps: upgrade npm to 3.10.8#8706

Closed
zkat wants to merge 2 commits into
nodejs:masterfrom
npm:npm-3.10.8
Closed

deps: upgrade npm to 3.10.8#8706
zkat wants to merge 2 commits into
nodejs:masterfrom
npm:npm-3.10.8

Conversation

@zkat

@zkat zkat commented Sep 22, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • deps
Description of change

Hey y'all!

I know it's been a while, since the npm CLI team moved to a monthly release cadence, but here's the latest and greatest in packaging technology!

Also! It might be of interest to y'all to know that the CLI team is planning to release npm@4 as our next latest with that October release. Of course, npm@3 will continue to be supported, since we're assuming it's what's gonna go into node@6 LTS. The breaking changes in npm@4 will be much less significant than those in npm@3 so it should have less impact overall. 👍

Notable Changes:
Changelogs

r: @thealphanerd
r: @addaleax

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Sep 22, 2016
@zkat

zkat commented Sep 22, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@Fishrock123 Fishrock123 self-assigned this Sep 22, 2016
@gibfahn

gibfahn commented Sep 22, 2016

Copy link
Copy Markdown
Member

@zkat So all tests passed except for one, and that one was fixed by upgrading to tap@7?

@zkat

zkat commented Sep 22, 2016

Copy link
Copy Markdown
Contributor Author

@gibfahn all tests should pass. I pushed a patch that bumps the tap version. This PR should not have any failing tests.

@Fishrock123

Fishrock123 commented Sep 22, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

git am fails with a conflict...?

curl -L https://github.com/nodejs/node/pull/8706.patch | git am
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   138    0   138    0     0    355      0 --:--:-- --:--:-- --:--:--   355
100 3817k    0 3817k    0     0  1490k      0 --:--:--  0:00:02 --:--:-- 1815k
Applying: deps: upgrade npm to 3.10.8
/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:2388: trailing whitespace.
The `--ignore-scripts` argument will cause npm to not execute any 
/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:2527: trailing whitespace.
3. Developer, works on packages they are given access to.  
/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:2536: trailing whitespace.
* Grant access:  
/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:2549: trailing whitespace.
default will only publish internally. 
/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:3139: trailing whitespace.
<p>The <code>--ignore-scripts</code> argument will cause npm to not execute any 


error: deps/npm/node_modules/request/node_modules/form-data/README.md: already exists in working directory
Patch failed at 0001 deps: upgrade npm to 3.10.8


The copy of the patch that failed is found in:
   /Users/Jeremiah/Documents/node/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

@Fishrock123

Fishrock123 commented Sep 22, 2016

Copy link
Copy Markdown
Contributor

Hmm, git am -3 seems to have worked. Running tests.

@zkat

zkat commented Sep 22, 2016

Copy link
Copy Markdown
Contributor Author

@Fishrock123 that's the casing bug again. It looks like my local copy of form-data's README is README.md (???), but the version in their repo is Readme.md (?!?!?!)

Siiiigh :\

@Fishrock123

Fishrock123 commented Sep 22, 2016

Copy link
Copy Markdown
Contributor

Tests passing, LGTM

@Fishrock123

Fishrock123 commented Sep 27, 2016

Copy link
Copy Markdown
Contributor

Fishrock123 pushed a commit that referenced this pull request Sep 27, 2016
@zkat @Fishrock123
deps: upgrade npm to 3.10.8
d44a9eb 
PR-URL: #8706
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123 pushed a commit that referenced this pull request Sep 27, 2016
@zkat @Fishrock123
deps: hotfix upgrade npm tap version for tests
6b443d1 
PR-URL: #8706
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
jasnell pushed a commit that referenced this pull request Sep 29, 2016
@zkat @jasnell
deps: upgrade npm to 3.10.8
089b289 
PR-URL: #8706
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
jasnell pushed a commit that referenced this pull request Sep 29, 2016
@zkat @jasnell
deps: hotfix upgrade npm tap version for tests
bb0af88 
PR-URL: #8706
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2016
@zkat
deps: upgrade npm to 3.10.8
9ecfc32 
PR-URL: #8706
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2016
@zkat
deps: hotfix upgrade npm tap version for tests
4d41bd9 
PR-URL: #8706
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123 added a commit that referenced this pull request Oct 12, 2016
@Fishrock123
2016-10-12, Version 6.8.0 (Current)
17145bd 
* fs:
  - `SyncWriteStream` now inherits from `Stream.Writable`. (Anna
Henningsen) #8830
    - Practically, this means that when stdio is piped to a file,
stdout and stderr will still be `Writable` streams.
  - `fs.existsSync()` has been undeprecated. `fs.exists()` remains
deprecated. (Dan Fabulich) #8364
* http: `http.request()` now accepts a `timeout` option. (Rene Weber)
#8101
* module: The module loader now maintains its own realpath cache. (Anna
Henningsen) #8100
* npm: Upgraded to 3.10.8 (Kat Marchán)
#8706
* stream: `Duplex` streams now show proper `instanceof
Stream.Writable`. (Anna Henningsen)
#8834
* timers: Improved `setTimeout`/`Interval` performance by up to 22%.
(Brian White) #8661

PR-URL: #9034
Fishrock123 added a commit that referenced this pull request Oct 12, 2016
@Fishrock123
2016-10-12, Version 6.8.0 (Current)
e4ee09a 
* fs:
  - `SyncWriteStream` now inherits from `Stream.Writable`. (Anna
Henningsen) #8830
    - Practically, this means that when stdio is piped to a file,
stdout and stderr will still be `Writable` streams.
  - `fs.existsSync()` has been undeprecated. `fs.exists()` remains
deprecated. (Dan Fabulich) #8364
* http: `http.request()` now accepts a `timeout` option. (Rene Weber)
#8101
* module: The module loader now maintains its own realpath cache. (Anna
Henningsen) #8100
* npm: Upgraded to 3.10.8 (Kat Marchán)
#8706
* stream: `Duplex` streams now show proper `instanceof
Stream.Writable`. (Anna Henningsen)
#8834
* timers: Improved `setTimeout`/`Interval` performance by up to 22%.
(Brian White) #8661

PR-URL: #9034
imyller added a commit to imyller/meta-nodejs that referenced this pull request Oct 13, 2016
@imyller
2016-10-12, Version 6.8.0 (Current)
c1a0496 
    * fs:
      - `SyncWriteStream` now inherits from `Stream.Writable`. (Anna
    Henningsen) nodejs/node#8830
        - Practically, this means that when stdio is piped to a file,
    stdout and stderr will still be `Writable` streams.
      - `fs.existsSync()` has been undeprecated. `fs.exists()` remains
    deprecated. (Dan Fabulich) nodejs/node#8364
    * http: `http.request()` now accepts a `timeout` option. (Rene Weber)
    nodejs/node#8101
    * module: The module loader now maintains its own realpath cache. (Anna
    Henningsen) nodejs/node#8100
    * npm: Upgraded to 3.10.8 (Kat Marchan)
    nodejs/node#8706
    * stream: `Duplex` streams now show proper `instanceof
    Stream.Writable`. (Anna Henningsen)
    nodejs/node#8834
    * timers: Improved `setTimeout`/`Interval` performance by up to 22%.
    (Brian White) nodejs/node#8661

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
imyller added a commit to imyller/meta-nodejs that referenced this pull request Oct 13, 2016
@imyller
2016-10-12, Version 6.8.0 (Current)
e6d3406 
    * fs:
      - `SyncWriteStream` now inherits from `Stream.Writable`. (Anna
    Henningsen) nodejs/node#8830
        - Practically, this means that when stdio is piped to a file,
    stdout and stderr will still be `Writable` streams.
      - `fs.existsSync()` has been undeprecated. `fs.exists()` remains
    deprecated. (Dan Fabulich) nodejs/node#8364
    * http: `http.request()` now accepts a `timeout` option. (Rene Weber)
    nodejs/node#8101
    * module: The module loader now maintains its own realpath cache. (Anna
    Henningsen) nodejs/node#8100
    * npm: Upgraded to 3.10.8 (Kat Marchan)
    nodejs/node#8706
    * stream: `Duplex` streams now show proper `instanceof
    Stream.Writable`. (Anna Henningsen)
    nodejs/node#8834
    * timers: Improved `setTimeout`/`Interval` performance by up to 22%.
    (Brian White) nodejs/node#8661

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
@wraithgar wraithgar deleted the npm-3.10.8 branch June 26, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Fishrock123 Fishrock123

Labels

npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zkat @gibfahn @Fishrock123 @MylesBorins @nodejs-github-bot