test: fix `test-config-json-schema` by aduh95 · Pull Request #66891 · nodejs/node · GitHub
Skip to content

test: fix test-config-json-schema - #66891

Closed
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:fix-test-config-json-schema
Closed

aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:fix-test-config-json-schema

Conversation

@aduh95

@aduh95 aduh95 commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 21, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 21, 2026
@aduh95

aduh95 commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Actually, it doesn't really make sense, the test should be disabled when QUIC is enabled – given that it's disabled by default. The QUIC job should skip this test on main yet it doesn't 🤔 in any case, that PR won't help

@aduh95 aduh95 closed this Oct 21, 2026
@aduh95
aduh95 deleted the fix-test-config-json-schema branch October 21, 2026 09:21
@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants