crypto: use `OPENSSL_SIZE_T` instead of hard coding `int` by aduh95 · Pull Request #66889 · nodejs/node · GitHub
Skip to content

crypto: use OPENSSL_SIZE_T instead of hard coding int - #66889

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:OPENSSL_SIZE_T
Oct 21, 2026
Merged

aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:OPENSSL_SIZE_T

Conversation

@aduh95

@aduh95 aduh95 commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

See https://github.com/nodejs/node/actions/runs/39508605253/job/118924784437?pr=66751. Introduced by #66871, which landed after the previous round at #66752

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Oct 21, 2026
@aduh95 aduh95 added fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95

aduh95 commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Requesting a fast-track given the change is trivial, and would unblock #66751 before more warnings are introduced

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 21, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.59%. Comparing base (796a83a) to head (a8f52b7).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66889      +/-   ##
==========================================
- Coverage   90.59%   90.59%   -0.01%     
==========================================
  Files         797      797              
  Lines      278362   278362              
  Branches    53505    53502       -3     
==========================================
- Hits       252195   252193       -2     
+ Misses      16521    16514       -7     
- Partials     9646     9655       +9     
Files with missing lines Coverage Δ
src/crypto/crypto_context.cc 72.45% <100.00%> (ø)

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95
aduh95 merged commit 39e03b4 into nodejs:main Oct 21, 2026
108 of 123 checks passed
@aduh95

aduh95 commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

@aduh95
aduh95 deleted the OPENSSL_SIZE_T branch October 21, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants