{{ message }}
Repository navigation
watch: escape quotes and backslashes in NODE_OPTIONS - #66363
Merged
Merged
Conversation
When stripping watch flags, NODE_OPTIONS is tokenized and rejoined for the child process. Values were only re-quoted if they contained a space, and nothing inside the quotes was escaped. A value with a double quote made the child fail with "unterminated string", and a backslash inside a quoted value was silently dropped. Quote values that contain a space or a double quote, and escape backslashes and double quotes inside the quotes, so the child tokenizes the string back to the same values. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
MoLow
approved these changes
Sep 28, 2026
trivikr
added
watch-mode
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Member
Author
trivikr
removed
the
author ready
MoLow
approved these changes
Sep 29, 2026
MoLow
added
the
author ready
trivikr
added
request-ci
nodejs-github-bot
added
the
lacks-second-approval
Collaborator
nodejs-github-bot
removed
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Oct 5, 2026
When stripping watch flags, NODE_OPTIONS is tokenized and rejoined for the child process. Values were only re-quoted if they contained a space, and nothing inside the quotes was escaped. A value with a double quote made the child fail with "unterminated string", and a backslash inside a quoted value was silently dropped. Quote values that contain a space or a double quote, and escape backslashes and double quotes inside the quotes, so the child tokenizes the string back to the same values. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5 PR-URL: #66363 Fixes: #66362 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66362
When stripping watch flags, NODE_OPTIONS is tokenized and rejoined for the child process. Values were only re-quoted if they contained a space, and nothing inside the quotes was escaped. A value with a double quote made the child fail with "unterminated string", and a backslash inside a quoted value was silently dropped.
Quote values that contain a space or a double quote, and escape backslashes and double quotes inside the quotes, so the child tokenizes the string back to the same values.
Assisted-by: claude:opus-5.5