{{ message }}
Repository navigation
buffer: fix negative index for large buffers - #66325
Merged
Merged
Conversation
nodejs-github-bot
added
buffer
Contributor
Dansatch
force-pushed
the
fix-buffer-indexof-2gib
branch
from
September 26, 2026 18:00
d1a0f65 to
04a1fd7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66325 +/- ##
==========================================
- Coverage 90.37% 90.36% -0.02%
==========================================
Files 790 792 +2
Lines 274514 275324 +810
Branches 52572 52768 +196
==========================================
+ Hits 248102 248785 +683
- Misses 16889 16964 +75
- Partials 9523 9575 +52
🚀 New features to boost your workflow:
|
panva
reviewed
Sep 26, 2026
panva
left a comment
panva
left a comment
Member
There was a problem hiding this comment.
Use int64_t instead of double for the casts and return types. The result is an integer offset or -1, and int64_t fixes the overflow while still exposing a JavaScript Number.
double also disables this Fast API signature on PPC64 and s390x. int64_t keeps it eligible.
Fix incorrect negative index results for large buffers. Add tests for number, Buffer and string searches beyond 2 GiB. Fixes: nodejs#66294 Signed-off-by: dansatch <dansatch98@gmail.com>
Dansatch
force-pushed
the
fix-buffer-indexof-2gib
branch
from
September 27, 2026 03:58
04a1fd7 to
7580065
Compare
Signed-off-by: dansatch <dansatch98@gmail.com>
addaleax
approved these changes
Sep 28, 2026
addaleax
added
author ready
panva
approved these changes
Sep 28, 2026
panva
added
the
commit-queue-squash
github-actions
Bot
removed
the
request-ci
Collaborator
panva
added
the
resume-ci
github-actions
Bot
removed
the
resume-ci
Collaborator
panva
added
the
resume-ci
github-actions
Bot
removed
the
resume-ci
Collaborator
panva
added
the
commit-queue
Collaborator
nodejs-github-bot
removed
the
commit-queue
HoonDongKang
pushed a commit
to HoonDongKang/node
that referenced
this pull request
Sep 29, 2026
Fix incorrect negative index results for large buffers. Add tests for number, Buffer and string searches beyond 2 GiB. Fixes: nodejs#66294 Signed-off-by: dansatch <dansatch98@gmail.com> PR-URL: nodejs#66325 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66294.
Buffer.prototype.indexOf()returned a negative position when a match occurred beyond 2 GiB because the result was converted to a signed 32-bit integer.This change returns the position as a JavaScript number and adds regression tests for number, Buffer, and string searches.