module: centralize builtin exposure policies by sjungwon03 · Pull Request #66292 · nodejs/node · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 47 additions & 29 deletions lib/internal/bootstrap/realm.js
72 changes: 3 additions & 69 deletions lib/internal/process/pre_execution.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,7 @@ function prepareExecution(options) {
setupNetworkInspection();
setupNavigator();
setupWarningHandler();
setupBench();
setupFFI();
setupSQLite();
setupStreamIter();
setupDTLS();
setupVfs();
setupQuic();
setupOptionGatedBuiltins();
setupWebStorage();
removeWebWorkersIfDisabled();
setupEventsource();
Expand Down Expand Up @@ -461,32 +455,9 @@ function setupNavigator() {
defineReplaceableLazyAttribute(globalThis, 'internal/navigator', ['navigator'], false);
}

function setupBench() {
if (!getOptionValue('--experimental-bench')) {
return;
}

const { BuiltinModule } = require('internal/bootstrap/realm');
BuiltinModule.allowRequireByUsers('bench');
BuiltinModule.allowRequireByUsers('bench/reporters');
}

function setupFFI() {
if (!getOptionValue('--experimental-ffi')) {
return;
}

const { BuiltinModule } = require('internal/bootstrap/realm');
BuiltinModule.allowRequireByUsers('ffi');
}

function setupSQLite() {
if (getOptionValue('--no-experimental-sqlite')) {
return;
}

function setupOptionGatedBuiltins() {
const { BuiltinModule } = require('internal/bootstrap/realm');
BuiltinModule.allowRequireByUsers('sqlite');
BuiltinModule.allowOptionGatedBuiltins(getOptionValue);
}

function initializeConfigFileSupport() {
Expand All @@ -495,43 +466,6 @@ function initializeConfigFileSupport() {
}
}

function setupStreamIter() {
if (!getOptionValue('--experimental-stream-iter')) {
return;
}

const { BuiltinModule } = require('internal/bootstrap/realm');
BuiltinModule.allowRequireByUsers('stream/iter');
BuiltinModule.allowRequireByUsers('zlib/iter');
}

function setupDTLS() {
if (!getOptionValue('--experimental-dtls')) {
return;
}

const { BuiltinModule } = require('internal/bootstrap/realm');
BuiltinModule.allowRequireByUsers('dtls');
}

function setupQuic() {
if (!getOptionValue('--experimental-quic')) {
return;
}

const { BuiltinModule } = require('internal/bootstrap/realm');
BuiltinModule.allowRequireByUsers('quic');
}

function setupVfs() {
if (!getOptionValue('--experimental-vfs')) {
return;
}

const { BuiltinModule } = require('internal/bootstrap/realm');
BuiltinModule.allowRequireByUsers('vfs');
}

function setupWebStorage() {
if (getEmbedderOptions().noBrowserGlobals ||
!getOptionValue('--experimental-webstorage')) {
Expand Down
8 changes: 7 additions & 1 deletion lib/internal/test/binding.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,10 @@ if (module.isPreloading) {
globalThis.primordials = primordials;
}

module.exports = { internalBinding: filteredInternalBinding, primordials };
module.exports = {
internalBinding: filteredInternalBinding,
primordials,
getBuiltinModulePolicies() {
return require('internal/bootstrap/realm').BuiltinModule.getBuiltinModulePolicies();
},
};
171 changes: 171 additions & 0 deletions test/parallel/test-module-builtin-policies.js
Loading