{{ message }}
Repository navigation
test: accept ENOTEMPTY from libc++ in test-fs-rm - #66065
Merged
nodejs-github-bot merged 1 commit intoSep 24, 2026
Merged
Conversation
fs.rmSync() is implemented with std::filesystem::remove_all(). When a read-only directory has a child, libc++ before LLVM 23 drops the child's EACCES and reports the ENOTEMPTY it then gets for the parent instead. The test pinned that behavior to macOS, but it depends on the C++ standard library rather than on the OS: a Linux build against libc++ fails the test when run as non-root, and macOS will start reporting EACCES once it ships the fixed libc++. Accept either code for that case on all POSIX platforms. Refs: llvm/llvm-project#197104 Refs: nodejs#57103 Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
nodejs-github-bot
added
needs-ci
meixg
approved these changes
Sep 17, 2026
codebytere
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
codebytere
added
the
commit-queue
Collaborator
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Sep 27, 2026
fs.rmSync() is implemented with std::filesystem::remove_all(). When a read-only directory has a child, libc++ before LLVM 23 drops the child's EACCES and reports the ENOTEMPTY it then gets for the parent instead. The test pinned that behavior to macOS, but it depends on the C++ standard library rather than on the OS: a Linux build against libc++ fails the test when run as non-root, and macOS will start reporting EACCES once it ships the fixed libc++. Accept either code for that case on all POSIX platforms. Refs: llvm/llvm-project#197104 Refs: #57103 Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #66065 Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: llvm/llvm-project#197104
Refs: #57103
fs.rmSync()is implemented withstd::filesystem::remove_all(). When a read-only directory has a child, libc++ before LLVM 23 drops the child'sEACCESand reports theENOTEMPTYit then gets for the parent instead (llvm/llvm-project#197104). #57103 pinned that to macOS intest-fs-rm, but it depends on the C++ standard library rather than on the OS: a Linux build against libc++ fails the read-only-subdirectory case when the suite runs as non-root, and macOS will start reportingEACCESonce it ships the fixed libc++.This accepts either code for that case on all POSIX platforms. Checked with a standalone
remove_all()program over the same directory layout - libstdc++ 13 reportsEACCES, libc++ 18 reportsENOTEMPTY- and by running the test as non-root against a regular (libstdc++) Linux build before and after.Disclosure: the code and this description were written by Claude Code, directed and reviewed by @codebytere.