{{ message }}
Repository navigation
src: reuse crypto GetCipherInfo in DTLS session - #66022
Merged
nodejs-github-bot merged 1 commit intoSep 18, 2026
Merged
Conversation
nodejs-github-bot
added
c++
aduh95
added
the
dtls
meixg
approved these changes
Sep 15, 2026
meixg
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
Member
|
This will need a rebase |
IlyasShabi
force-pushed
the
ishabi/dtls-getcipherinfo-crypto
branch
2 times, most recently
from
September 16, 2026 09:27
c20e9ba to
e208c95
Compare
Signed-off-by: ishabi <ilyasshabi94@gmail.com>
IlyasShabi
force-pushed
the
ishabi/dtls-getcipherinfo-crypto
branch
from
September 16, 2026 09:54
e208c95 to
d1044c4
Compare
Member
Author
|
@jasnell could you please check again? |
jasnell
approved these changes
Sep 17, 2026
IlyasShabi
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
IlyasShabi
added
author ready
Collaborator
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Sep 18, 2026
Signed-off-by: ishabi <ilyasshabi94@gmail.com> PR-URL: #66022 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call shared crypto
GetCipherInfohelper insideDTLSSession::GetCipherinstead of using same code, this also using cached DictionaryTemplate.