lib: fix AbortSignal.any() abort propagation by inoway46 · Pull Request #66014 · nodejs/node · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/internal/abort_controller.js
31 changes: 31 additions & 0 deletions test/parallel/test-abortsignal-any-source-gc.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
// Flags: --expose-gc

import '../common/index.mjs';
import { gcUntil } from '../common/gc.js';
import assert from 'node:assert/strict';
import { it } from 'node:test';

for (const nested of [false, true]) {
for (const accessor of ['aborted', 'reason', 'throwIfAborted']) {
it(`preserves ${accessor} after source GC (nested: ${nested})`, async () => {
let controller = new AbortController();
const sourceRef = new WeakRef(controller.signal);
let signal = AbortSignal.any([controller.signal]);
if (nested) signal = AbortSignal.any([signal]);
const reason = { message: 'stop' };

controller.abort(reason);
controller = null;

// Do not observe the composite or attach a listener before source GC.
await gcUntil('source signal is collected', () => sourceRef.deref() === undefined);

// Exercise each entry point before any other accessor can refresh state.
if (accessor === 'aborted') assert.strictEqual(signal.aborted, true);
if (accessor === 'reason') assert.strictEqual(signal.reason, reason);
assert.throws(() => signal.throwIfAborted(), (err) => err === reason);
assert.strictEqual(signal.aborted, true);
assert.strictEqual(signal.reason, reason);
});
}
}
34 changes: 29 additions & 5 deletions test/parallel/test-abortsignal-drop-settled-signals.mjs
Loading