test: fix stderr Buffer assertion in exec encoding test by greenheadHQ · Pull Request #66008 · nodejs/node · GitHub
Skip to content

test: fix stderr Buffer assertion in exec encoding test - #66008

Closed
greenheadHQ wants to merge 1 commit into
nodejs:mainfrom
greenheadHQ:feat/exec-encoding-stderr-assertion
Closed

test: fix stderr Buffer assertion in exec encoding test#66008
greenheadHQ wants to merge 1 commit into
nodejs:mainfrom
greenheadHQ:feat/exec-encoding-stderr-assertion

Conversation

@greenheadHQ

@greenheadHQ greenheadHQ commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Replace the duplicate stdout assertion with the missing stderr Buffer assertion. The introducing PR also aimed to improve stderr coverage.

Refs: #10919

@greenheadHQ
test: fix stderr Buffer assertion in exec encoding test
2c6d24a 
Signed-off-by: greenhead <greenheadhq@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 13, 2026
@codecov

codecov Bot commented Sep 13, 2026 •
edited
Loading

Copy link
Copy Markdown

@meixg meixg added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 14, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 14, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77448/

@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 14, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77462/

@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77475/

@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 15, 2026
panva pushed a commit that referenced this pull request Sep 15, 2026
@greenheadHQ @panva
test: fix stderr Buffer assertion in exec encoding test
26dbe11 
Signed-off-by: greenhead <greenheadhq@gmail.com>
PR-URL: #66008
Refs: #10919
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@panva

panva commented Sep 15, 2026

Copy link
Copy Markdown
Member

@panva panva closed this Sep 15, 2026
@panva panva removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 15, 2026
aduh95 pushed a commit that referenced this pull request Sep 16, 2026
@greenheadHQ @aduh95
test: fix stderr Buffer assertion in exec encoding test
8929730 
Signed-off-by: greenhead <greenheadhq@gmail.com>
PR-URL: #66008
Refs: #10919
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@github-actions github-actions Bot mentioned this pull request Sep 20, 2026
Merged
aduh95 pushed a commit that referenced this pull request Sep 22, 2026
@greenheadHQ @aduh95
test: fix stderr Buffer assertion in exec encoding test
f091568 
Signed-off-by: greenhead <greenheadhq@gmail.com>
PR-URL: #66008
Refs: #10919
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
aduh95 pushed a commit that referenced this pull request Sep 25, 2026
@greenheadHQ @aduh95
test: fix stderr Buffer assertion in exec encoding test
b8c5283 
Signed-off-by: greenhead <greenheadhq@gmail.com>
PR-URL: #66008
Refs: #10919
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@github-actions github-actions Bot mentioned this pull request Oct 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@meixg meixg meixg approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@greenheadHQ @nodejs-github-bot @panva @jasnell @lpinca @UlisesGascon @meixg @aduh95