sqlite: remove classes sync suffix by araujogui · Pull Request #65988 · nodejs/node · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions SECURITY.md
2 changes: 1 addition & 1 deletion benchmark/sqlite/sqlite-diagnostic-channel.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const bench = common.createBenchmark(main, {
function main(conf) {
const { n, mode } = conf;

const db = new sqlite.DatabaseSync(':memory:');
const db = new sqlite.Database(':memory:');
db.exec('CREATE TABLE t (x INTEGER)');
const insert = db.prepare('INSERT INTO t VALUES (?)');

Expand Down
2 changes: 1 addition & 1 deletion benchmark/sqlite/sqlite-is-transaction.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const bench = common.createBenchmark(main, {
});

function main(conf) {
const db = new sqlite.DatabaseSync(':memory:');
const db = new sqlite.Database(':memory:');

if (conf.transaction === 'true') {
db.exec('BEGIN');
Expand Down
2 changes: 1 addition & 1 deletion benchmark/sqlite/sqlite-prepare-insert.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const bench = common.createBenchmark(main, {
});

function main(conf) {
const db = new sqlite.DatabaseSync(':memory:');
const db = new sqlite.Database(':memory:');

db.exec('CREATE TABLE text_column_type (text_column TEXT)');
db.exec('CREATE TABLE integer_column_type (integer_column INTEGER)');
Expand Down
2 changes: 1 addition & 1 deletion benchmark/sqlite/sqlite-prepare-select-all-options.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function main(conf) {
return acc;
}, {});

const db = new sqlite.DatabaseSync(':memory:', optionsObj);
const db = new sqlite.Database(':memory:', optionsObj);

db.exec(
'CREATE TABLE foo (text_column TEXT, integer_column INTEGER, real_column REAL, blob_column BLOB)',
Expand Down
2 changes: 1 addition & 1 deletion benchmark/sqlite/sqlite-prepare-select-all.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const bench = common.createBenchmark(main, {
});

function main(conf) {
const db = new sqlite.DatabaseSync(':memory:');
const db = new sqlite.Database(':memory:');

// Create only the necessary table for the benchmark type.
// If the statement includes 'foo_large', create the foo_large table; otherwise, create the foo table.
Expand Down
2 changes: 1 addition & 1 deletion benchmark/sqlite/sqlite-prepare-select-get-options.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function main(conf) {
return acc;
}, {});

const db = new sqlite.DatabaseSync(':memory:', optionsObj);
const db = new sqlite.Database(':memory:', optionsObj);

db.exec(
'CREATE TABLE foo (text_column TEXT, integer_column INTEGER, real_column REAL, blob_column BLOB)',
Expand Down
2 changes: 1 addition & 1 deletion benchmark/sqlite/sqlite-prepare-select-get.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const bench = common.createBenchmark(main, {
});

function main(conf) {
const db = new sqlite.DatabaseSync(':memory:');
const db = new sqlite.Database(':memory:');

// Create only the necessary table for the benchmark type.
// If the statement includes 'foo_large', create the foo_large table; otherwise, create the foo table.
Expand Down
28 changes: 28 additions & 0 deletions doc/api/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -4801,6 +4801,34 @@ async function example() {
}
```

### DEP0210: `sqlite.DatabaseSync`

<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/65988
description: Documentation-only deprecation.
-->

Type: Documentation-only

`node:sqlite`'s `DatabaseSync` class was renamed to `Database`. `DatabaseSync`
is kept as a deprecated alias. Use `Database` instead.
Comment thread
araujogui marked this conversation as resolved.

### DEP0211: `sqlite.StatementSync`

<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/65988
description: Documentation-only deprecation.
-->

Type: Documentation-only

`node:sqlite`'s `StatementSync` class was renamed to `Statement`.
`StatementSync` is kept as a deprecated alias. Use `Statement` instead.

[DEP0142]: #dep0142-repl_builtinlibs
[DEP0156]: #dep0156-aborted-property-and-abort-aborted-event-in-http
[NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
Expand Down
6 changes: 3 additions & 3 deletions doc/api/diagnostics_channel.md
Loading
Loading