{{ message }}
Repository navigation
test: fix RSA/DSA wrong-passphrase flake - #65983
Merged
nodejs-github-bot merged 1 commit intoSep 14, 2026
Merged
Conversation
Re-encrypting keys on each FIPS test run can produce ciphertext that decrypts with valid padding under the wrong password, causing a decoder error instead of the expected bad decrypt. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
panva
added
the
flaky-test
nodejs-github-bot
added
needs-ci
jasnell
approved these changes
Sep 11, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
panva
added
the
commit-queue
nodejs-github-bot
added
the
lacks-second-approval
Collaborator
nodejs-github-bot
removed
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Sep 16, 2026
Re-encrypting keys on each FIPS test run can produce ciphertext that decrypts with valid padding under the wrong password, causing a decoder error instead of the expected bad decrypt. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex PR-URL: #65983 Refs: https://github.com/nodejs/node/actions/runs/34595689099/job/103251404626?pr=65980 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 25, 2026
Re-encrypting keys on each FIPS test run can produce ciphertext that decrypts with valid padding under the wrong password, causing a decoder error instead of the expected bad decrypt. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex PR-URL: #65983 Backport-PR-URL: #66233 Refs: https://github.com/nodejs/node/actions/runs/34595689099/job/103251404626?pr=65980 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
panva
added
backported-to-v24.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deflakes
test/parallel/test-crypto-rsa-dsa.js.Re-encrypting keys on each FIPS test run can produce ciphertext that decrypts with valid padding under the wrong password, causing a decoder error instead of the expected bad decrypt.
Assisted-by: Codex
Refs: https://github.com/nodejs/node/actions/runs/34595689099/job/103251404626?pr=65980