vfs: validate ZipProvider parent directories by trivikr · Pull Request #65829 · nodejs/node · GitHub
Skip to content

vfs: validate ZipProvider parent directories - #65829

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:vfs-zip-provider-non-dir-parents
Open

vfs: validate ZipProvider parent directories#65829
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:vfs-zip-provider-non-dir-parents

Conversation

@trivikr

@trivikr trivikr commented Sep 5, 2026

Copy link
Copy Markdown
Member

Fixes: #65828

Reject attempts to create archive entries beneath non-directory parents. Cover open, mkdir, and rename in the sync and async APIs.


Assisted-by: codex

Reject attempts to create archive entries beneath non-directory
parents. Cover open, mkdir, and rename in the sync and async APIs.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem. labels Sep 5, 2026
@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

@trivikr

trivikr commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

FYI: @pipobscure

@trivikr trivikr added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Sep 6, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vfs: ZipProvider allows creating entries beneath non-directory parents

3 participants