{{ message }}
Repository navigation
vfs: support renaming implicit ZIP directories - #65752
Merged
Merged
Conversation
nodejs-github-bot
added
needs-ci
trivikr
added
the
request-ci
Member
|
@pipobscure ... just want to get your review on this as well. |
jasnell
approved these changes
Sep 3, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
added
the
author ready
pipobscure
reviewed
Sep 4, 2026
Contributor
|
LGTM definitely a step in the right direction. Made me think of another edgecase where the provider could be better in a write/rename situation. |
Contributor
|
In this context, we (probably I) should also take a look at #65373 to make sure the bahaviour is fully correct for ZipArchives. Decision Needed: merge this and then fix the issues as this is already a significant improvement, or fix the latent rename issues in one go. My €0.02 is to merge and continue improving, that's after all what --experimental is for. |
trivikr
added
the
commit-queue
trivikr
force-pushed
the
vfs-zip-provider-rename
branch
from
September 4, 2026 13:18
1bb560a to
8e7df26
Compare
trivikr
removed
commit-queue
Member
Author
|
Re-requested a review from @jasnell as a regression test was added based on feedback in #65752 (comment) |
jasnell
approved these changes
Sep 4, 2026
trivikr
added
request-ci
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
added
the
commit-queue
nodejs-github-bot
added
lacks-second-approval
nodejs-github-bot
removed
the
lacks-second-approval
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
removed
commit-queue-failed
Treat archive entry prefixes as directories when renaming with ZipProvider. Move all descendant entries to the new prefix for both asynchronous and synchronous operations. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
trivikr
force-pushed
the
vfs-zip-provider-rename
branch
from
September 9, 2026 05:22
8e7df26 to
5263f98
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Member
Author
|
@jasnell Can you provide your approval again? I had to rebase on Sep 9th to resolve conflicts. |
trivikr
added
author ready
Collaborator
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Sep 16, 2026
Treat archive entry prefixes as directories when renaming with ZipProvider. Move all descendant entries to the new prefix for both asynchronous and synchronous operations. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #65752 Fixes: #65751 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65751
Treat archive entry prefixes as directories when renaming with ZipProvider. Move all descendant entries to the new prefix for both asynchronous and synchronous operations.
Assisted-by: codex:gpt-5.6-sol