vfs: return FileHandle from fs.promises.open by trivikr · Pull Request #65730 · nodejs/node · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions lib/internal/vfs/fd.js
5 changes: 2 additions & 3 deletions lib/internal/vfs/setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const {
getLayerIdFromPath,
getNormalizedVfsRoot,
} = require('internal/vfs/router');
const { getVirtualFd, closeVirtualFd } = require('internal/vfs/fd');
const { getVirtualFd, closeVirtualFd, createVfsFileHandle } = require('internal/vfs/fd');
const { assertEncoding, setVfsHandlers } = require('internal/fs/utils');
const permission = require('internal/process/permission');
const { getOptionValue } = require('internal/options');
Expand Down Expand Up @@ -786,8 +786,7 @@ function createVfsHandlers() {
const r = findVFSForPath(pathStr);
if (r !== null) {
const fd = r.vfs.openSync(r.path, flags, mode);
const vfd = getVirtualFd(fd);
return PromiseResolve(vfd.entry);
return PromiseResolve(createVfsFileHandle(getVirtualFd(fd)));
}
}
return undefined;
Expand Down
3 changes: 3 additions & 0 deletions test/parallel/test-vfs-fs-promises.js
Loading