{{ message }}
Repository navigation
test: remove console.log call in node_run_list - #65572
Merged
Merged
Conversation
nodejs-github-bot
added
needs-ci
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
added
the
request-ci
panva
approved these changes
Aug 28, 2026
panva
added
the
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
lpinca
approved these changes
Aug 28, 2026
Collaborator
aduh95
added
the
commit-queue
Collaborator
nodejs-github-bot
removed
the
commit-queue
aduh95
added a commit
that referenced
this pull request
Sep 3, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65572 Refs: https://github.com/nodejs/node/pull/65552/changes#r3862720795 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
added a commit
that referenced
this pull request
Sep 15, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65572 Refs: https://github.com/nodejs/node/pull/65552/changes#r3862720795 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That
console.loglooks like a debug thing, when in fact the test relies on it as this is a message test. Switch to using the more appropriateinheritvalue.Refs: https://github.com/nodejs/node/pull/65552/changes#r3862720795