{{ message }}
Repository navigation
test: avoid orphaned child on Windows abort test - #65451
Merged
Merged
Conversation
Fixes: nodejs#58118 Signed-off-by: PickBas <sayed.kirill@gmail.com>
nodejs-github-bot
added
needs-ci
StefanStojanovic
approved these changes
Aug 27, 2026
StefanStojanovic
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
gurgunday
approved these changes
Aug 31, 2026
StefanStojanovic
added
the
commit-queue
Collaborator
nodejs-github-bot
removed
the
commit-queue
R31K4G3
pushed a commit
to R31K4G3/node
that referenced
this pull request
Sep 9, 2026
Fixes: nodejs#58118 Signed-off-by: PickBas <sayed.kirill@gmail.com> PR-URL: nodejs#65451 Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows,
test-child-process-exec-abortcontroller-promisifiedcan leave straynode.exeprocesses behind after the test exits.exec()runs the command throughcmd.exe, andcmd.execannot replace itself with the command it runs, so thenode.exestarted for-e "setInterval(()=>{}, 99)"is a grandchild.child.kill()terminates only the direct child, leaving that grandchild orphaned if the kill lands aftercmd.exehas already created it. This is timing-dependent and does not reproduce on every machine.Fix
Use the
cmd.exebuiltinpauseas the wait command. It blocks on the stdin pipe thatexec()opens and spawns no process of its own, socmd.exeis the only process in the tree and killing it leaves nothing behind.Fixes: #58118